Bug 88130 - [BlackBerry] Fix the return value checking in SelectPopupClient
Summary: [BlackBerry] Fix the return value checking in SelectPopupClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 13:33 PDT by Crystal Zhang
Modified: 2012-06-01 15:34 PDT (History)
2 users (show)

See Also:


Attachments
patch (2.33 KB, patch)
2012-06-01 13:36 PDT, Crystal Zhang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Crystal Zhang 2012-06-01 13:33:06 PDT
In SelectPopupClient, return '1' means selected, '0' means not selected, the ASCII value of '0' is 48, not 32, use '0' to be more readable.
Comment 1 Crystal Zhang 2012-06-01 13:36:52 PDT
Created attachment 145370 [details]
patch
Comment 2 Rob Buis 2012-06-01 13:46:46 PDT
Comment on attachment 145370 [details]
patch

Looks good.
Comment 3 WebKit Review Bot 2012-06-01 15:34:47 PDT
Comment on attachment 145370 [details]
patch

Clearing flags on attachment: 145370

Committed r119290: <http://trac.webkit.org/changeset/119290>
Comment 4 WebKit Review Bot 2012-06-01 15:34:51 PDT
All reviewed patches have been landed.  Closing bug.