Bug 88120 - EventTarget.idl should generate JS bindings
Summary: EventTarget.idl should generate JS bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Cooney
URL:
Keywords:
Depends on:
Blocks: 67312
  Show dependency tree / graph
 
Reported: 2012-06-01 12:07 PDT by Dominic Cooney
Modified: 2012-06-03 20:06 PDT (History)
13 users (show)

See Also:

Attachments
WIP Patch (25.90 KB, patch)
2012-06-01 12:13 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
WIP Patch (28.33 KB, patch)
2012-06-02 10:14 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
WIP Patch (29.13 KB, patch)
2012-06-03 03:43 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
Patch (29.41 KB, patch)
2012-06-03 07:46 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2012-06-01 12:07:39 PDT 
For EventTarget to move to the prototype chain and have a constructor (see bug 67312) the JSC binding generation should process EventTarget.idl. Review comments on attachment 110260 [details] suggested making this change separately.
Comment 1 Dominic Cooney 2012-06-01 12:13:39 PDT 
Created attachment 145352 [details]
WIP Patch
Comment 2 Early Warning System Bot 2012-06-01 12:24:26 PDT 
Comment on attachment 145352 [details]
WIP Patch

Attachment 145352 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12861718
Comment 3 Early Warning System Bot 2012-06-01 13:24:00 PDT 
Comment on attachment 145352 [details]
WIP Patch

Attachment 145352 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12861741
Comment 4 Adam Barth 2012-06-01 13:50:47 PDT 
Comment on attachment 145352 [details]
WIP Patch

Looks like you've got some compile trouble on Qt.  I'll need to study this patch more closely before r+ing it, but it looks reasonable at first glance.
Comment 5 Gyuyoung Kim 2012-06-01 14:18:30 PDT 
Comment on attachment 145352 [details]
WIP Patch

Attachment 145352 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12865667
Comment 6 WebKit Review Bot 2012-06-01 16:06:43 PDT 
Comment on attachment 145352 [details]
WIP Patch

Attachment 145352 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12868655
Comment 7 Dominic Cooney 2012-06-01 19:23:08 PDT 
Comment on attachment 145352 [details]
WIP Patch

Looks like this needs more work.
Comment 8 Dominic Cooney 2012-06-02 10:14:50 PDT 
Created attachment 145448 [details]
WIP Patch

To bake on bots.
Comment 9 Gustavo Noronha (kov) 2012-06-02 10:24:59 PDT 
Comment on attachment 145448 [details]
WIP Patch

Attachment 145448 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12869800
Comment 10 Gyuyoung Kim 2012-06-02 10:42:22 PDT 
Comment on attachment 145448 [details]
WIP Patch

Attachment 145448 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12869803
Comment 11 Dominic Cooney 2012-06-03 03:43:36 PDT 
Created attachment 145479 [details]
WIP Patch
Comment 12 Dominic Cooney 2012-06-03 07:46:35 PDT 
Created attachment 145482 [details]
Patch
Comment 13 Dominic Cooney 2012-06-03 08:13:40 PDT 
Comment on attachment 145482 [details]
Patch

Think this is good to go now.
Comment 14 WebKit Review Bot 2012-06-03 20:06:37 PDT 
Comment on attachment 145482 [details]
Patch

Clearing flags on attachment: 145482

Committed r119367: <http://trac.webkit.org/changeset/119367>
Comment 15 WebKit Review Bot 2012-06-03 20:06:43 PDT 
All reviewed patches have been landed.  Closing bug.