Bug 88119 – REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

REGRESSION (r99448) Zero-sized plugins never get an NPP_SetWindow call

The regression from 99448 was specifically about Netscape plug-ins on Mac, but it's a theoretical problem on all WK2 ports.

In radar as <rdar://problem/11335622>

[Brady Eidson]

Created attachment 145354 [details]
Patch v1

[Anders Carlsson]

Comment on attachment 145354 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=145354&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:715
> +    m_hasCalledSetWindow = true;

I think you should set this to true in callSetWindow, since it can be called from platformPaint as well.

[Brady Eidson]

http://trac.webkit.org/changeset/119260

[Brady Eidson]

(In reply to comment #2)
> (From update of attachment 145354 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145354&action=review
> 
> > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:715
> > +    m_hasCalledSetWindow = true;
> 
> I think you should set this to true in callSetWindow, since it can be called from platformPaint as well.

I was trying to keep it local to where it was used, having done an (apparently faulty) search for other callers and coming up empty.

Makes sense, and will do in a followup.

[Brady Eidson]

Followed up in http://trac.webkit.org/changeset/119261