Bug 88110 – Prepare table collapsed border computation to support mixed directionality on row group

• Status: RESOLVED
• Resolution: FIXED
• Component: Tables

[Julien Chaffraix]

The code doesn't handle mixed directionality inside a table and will fail pretty badly if it is involved. CSS 2.1 and CSS 3 writing-modes however allow the use of mixed directionality.

The difficulty with mixed directionality is that the start / end borders don't map strictly anymore: the table start border will be the section's end border if the table and section have mixed directionality.

To account for that, we need new methods to properly get the adjoining borders regardless of the directions.

[Julien Chaffraix]

Created attachment 145340 [details]
Proposed preparation. Comments on naming more than welcome.

[Julien Chaffraix]

CC'ing some people who could comment on the naming used.

[Ojan Vafai]

Comment on attachment 145340 [details]
Proposed preparation. Comments on naming more than welcome.

View in context: https://bugs.webkit.org/attachment.cgi?id=145340&action=review

> Source/WebCore/ChangeLog:14
> +        This change add the concept of adjoining borders in the table direction so that we can safely

s/add/adds

> Source/WebCore/rendering/RenderTableSection.h:127
> +    // These methods handle mixed directions between table and sections.

Meh. This is a what comment. That will be clear once you do your followup patch. No need to add a comment saying it.

[Julien Chaffraix]

Created attachment 145356 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 145356 [details]
Patch for landing

Clearing flags on attachment: 145356

Committed r119272: <http://trac.webkit.org/changeset/119272>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.