Bug 88106 - Crash in WebCore::FontFallbackList::determinePitch
Summary: Crash in WebCore::FontFallbackList::determinePitch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eli Fidler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 10:12 PDT by Eli Fidler
Modified: 2012-06-02 14:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2012-06-01 10:15 PDT, Eli Fidler 		no flags Details | Formatted Diff | Diff
Patch (1.79 KB, patch)
2012-06-01 14:16 PDT, Eli Fidler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eli Fidler 2012-06-01 10:12:50 PDT 
If the site doesn't ask for a reasonable font and the system doesn't provide a good fallback, FontFallBackList::primaryFontData can be 0.
Comment 1 Eli Fidler 2012-06-01 10:15:57 PDT 
Created attachment 145335 [details]
Patch
Comment 2 mitz 2012-06-01 12:03:04 PDT 
Comment on attachment 145335 [details]
Patch

There are many places in the code that require primaryFontData to be non-0. This bug should be fixed in the FontCache implementation so that it always provides some font as a last resort.
Comment 3 Eli Fidler 2012-06-01 14:16:36 PDT 
Created attachment 145375 [details]
Patch
Comment 4 WebKit Review Bot 2012-06-02 14:52:50 PDT 
Comment on attachment 145375 [details]
Patch

Clearing flags on attachment: 145375

Committed r119340: <http://trac.webkit.org/changeset/119340>
Comment 5 WebKit Review Bot 2012-06-02 14:53:04 PDT 
All reviewed patches have been landed.  Closing bug.