Bug 88104 – rename -webkit-flex-order to -webkit-order

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

rename -webkit-flex-order to -webkit-order

[Tony Chang]

Created attachment 145329 [details]
Patch

[Ojan Vafai]

Comment on attachment 145329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145329&action=review

> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:149
> +    int m_order;

It's a bummer that we use so many bits for this. :( What do we do for z-index? Also, per-spec, isn't this a float now? Obviously, none of these changes would happen in this patch. Just bringing it up since I'm noticing the code.

[Tony Chang]

(In reply to comment #2)
> (From update of attachment 145329 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145329&action=review
> 
> > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:149
> > +    int m_order;
> 
> It's a bummer that we use so many bits for this. :( What do we do for z-index?

z-index is an int.  It hangs off of StyleBoxData which has things like min/max width/height and vertical align.

> Also, per-spec, isn't this a float now? Obviously, none of these changes would happen in this patch. Just bringing it up since I'm noticing the code.

Huh, I didn't notice that change.  I've filed 88111 for this.

[WebKit Review Bot]

Comment on attachment 145329 [details]
Patch

Clearing flags on attachment: 145329

Committed r119255: <http://trac.webkit.org/changeset/119255>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.