Bug 88104 - rename -webkit-flex-order to -webkit-order
Summary: rename -webkit-flex-order to -webkit-order
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency treegraph
 
Reported: 2012-06-01 09:36 PDT by Tony Chang
Modified: 2012-06-01 11:13 PDT (History)
6 users (show)

See Also:


Attachments
Patch (86.11 KB, patch)
2012-06-01 09:37 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-06-01 09:36:45 PDT
rename -webkit-flex-order to -webkit-order
Comment 1 Tony Chang 2012-06-01 09:37:56 PDT
Created attachment 145329 [details]
Patch
Comment 2 Ojan Vafai 2012-06-01 10:13:15 PDT
Comment on attachment 145329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145329&action=review

> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:149
> +    int m_order;

It's a bummer that we use so many bits for this. :( What do we do for z-index? Also, per-spec, isn't this a float now? Obviously, none of these changes would happen in this patch. Just bringing it up since I'm noticing the code.
Comment 3 Tony Chang 2012-06-01 11:08:41 PDT
(In reply to comment #2)
> (From update of attachment 145329 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145329&action=review
> 
> > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:149
> > +    int m_order;
> 
> It's a bummer that we use so many bits for this. :( What do we do for z-index?

z-index is an int.  It hangs off of StyleBoxData which has things like min/max width/height and vertical align.

> Also, per-spec, isn't this a float now? Obviously, none of these changes would happen in this patch. Just bringing it up since I'm noticing the code.

Huh, I didn't notice that change.  I've filed 88111 for this.
Comment 4 WebKit Review Bot 2012-06-01 11:13:10 PDT
Comment on attachment 145329 [details]
Patch

Clearing flags on attachment: 145329

Committed r119255: <http://trac.webkit.org/changeset/119255>
Comment 5 WebKit Review Bot 2012-06-01 11:13:14 PDT
All reviewed patches have been landed.  Closing bug.