Bug 88103 - [Chromium] imageSmoothingEnabled should apply to patterns
Summary: [Chromium] imageSmoothingEnabled should apply to patterns
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 09:21 PDT by Keyar Hood
Modified: 2012-06-06 08:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (15.41 KB, patch)
2012-06-04 14:15 PDT, Keyar Hood
no flags Details | Formatted Diff | Diff
Patch (15.76 KB, patch)
2012-06-05 08:47 PDT, Keyar Hood
no flags Details | Formatted Diff | Diff
Patch (15.74 KB, patch)
2012-06-05 15:08 PDT, Keyar Hood
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keyar Hood 2012-06-01 09:21:00 PDT
The spec recently updated for HTML5 canvas and now imageSmoothingEnabled should apply to patterns. Currently, only nearest neighbour is done for interpolation when patterns are drawn for chromium even if imageSmoothingEnabled is set to true.
Comment 1 Keyar Hood 2012-06-04 14:15:16 PDT
Created attachment 145625 [details]
Patch
Comment 2 Stephen White 2012-06-05 08:14:44 PDT
It looks like some tests are still failing on the cr-linux bot, including your new test:

  platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns.html = IMAGE
  svg/W3C-SVG-1.1/pservers-grad-06-b.svg = IMAGE
  svg/custom/pattern-with-transformation.svg = IMAGE

I think the latter two should probably be marked for rebaselining as well.

Also, the patch is conflicting in TestExpectations and won't apply.  Please update, add those two tests above, and re-upload.  (You can also move the chunk of failing tests to a different part of TestExpectations to avoid conflicts if you like).
Comment 3 Keyar Hood 2012-06-05 08:47:32 PDT
Created attachment 145808 [details]
Patch
Comment 4 Keyar Hood 2012-06-05 15:08:01 PDT
Created attachment 145877 [details]
Patch
Comment 5 Stephen White 2012-06-06 08:06:55 PDT
Comment on attachment 145877 [details]
Patch

Great, thanks.  r=me
Comment 6 WebKit Review Bot 2012-06-06 08:17:42 PDT
Comment on attachment 145877 [details]
Patch

Clearing flags on attachment: 145877

Committed r119591: <http://trac.webkit.org/changeset/119591>
Comment 7 WebKit Review Bot 2012-06-06 08:17:49 PDT
All reviewed patches have been landed.  Closing bug.