RESOLVED FIXED 88097
[chromium] replace isScrollGestureEventType with isGestureEventType 
https://bugs.webkit.org/show_bug.cgi?id=88097
Summary [chromium] replace isScrollGestureEventType with isGestureEventType
Robert Kroeger
Reported 2012-06-01 08:14:35 PDT
In Chromium WebInputEvent, isGestureScrollEventType is incorrect. It includes gesture event types that are not scroll gestures so serves neither the purpose of identifying a gesture event or the purpose of identifying a scrolling gesture event. Correct the method's name and function.
Attachments
Patch (2.33 KB, patch)
2012-06-01 14:38 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2012-06-01 14:53 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Kroeger
Comment 1 2012-06-01 14:38:27 PDT
Created attachment 145378 [details] Patch
Robert Kroeger
Comment 2 2012-06-01 14:39:29 PDT
abarth@: Could you review please?
WebKit Review Bot
Comment 3 2012-06-01 14:40:21 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 4 2012-06-01 14:42:10 PDT
Comment on attachment 145378 [details] Patch This is fine, but you've got an extra space after the == operators.
Robert Kroeger
Comment 5 2012-06-01 14:53:47 PDT
Created attachment 145382 [details] Patch
Robert Kroeger
Comment 6 2012-06-01 14:55:46 PDT
abarth@: fixed. PTAL. Sorry I forgot the --no-review.
WebKit Review Bot
Comment 7 2012-06-03 00:07:10 PDT
Comment on attachment 145382 [details] Patch Clearing flags on attachment: 145382 Committed r119355: <http://trac.webkit.org/changeset/119355>
WebKit Review Bot
Comment 8 2012-06-03 00:07:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.