Bug 88097 - [chromium] replace isScrollGestureEventType with isGestureEventType
Summary: [chromium] replace isScrollGestureEventType with isGestureEventType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Kroeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 08:14 PDT by Robert Kroeger
Modified: 2012-06-03 00:07 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.33 KB, patch)
2012-06-01 14:38 PDT, Robert Kroeger
no flags Details | Formatted Diff | Diff
Patch (2.11 KB, patch)
2012-06-01 14:53 PDT, Robert Kroeger
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kroeger 2012-06-01 08:14:35 PDT
In Chromium WebInputEvent, isGestureScrollEventType is incorrect. It includes gesture event types that are not scroll gestures so serves neither the purpose of identifying a gesture event or the purpose of identifying a scrolling gesture event. Correct the method's name and function.
Comment 1 Robert Kroeger 2012-06-01 14:38:27 PDT
Created attachment 145378 [details]
Patch
Comment 2 Robert Kroeger 2012-06-01 14:39:29 PDT
abarth@: Could you review please?
Comment 3 WebKit Review Bot 2012-06-01 14:40:21 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Adam Barth 2012-06-01 14:42:10 PDT
Comment on attachment 145378 [details]
Patch

This is fine, but you've got an extra space after the == operators.
Comment 5 Robert Kroeger 2012-06-01 14:53:47 PDT
Created attachment 145382 [details]
Patch
Comment 6 Robert Kroeger 2012-06-01 14:55:46 PDT
abarth@: fixed. PTAL. 

Sorry I forgot the --no-review.
Comment 7 WebKit Review Bot 2012-06-03 00:07:10 PDT
Comment on attachment 145382 [details]
Patch

Clearing flags on attachment: 145382

Committed r119355: <http://trac.webkit.org/changeset/119355>
Comment 8 WebKit Review Bot 2012-06-03 00:07:16 PDT
All reviewed patches have been landed.  Closing bug.