Bug 88095 - [Qt][WK2] Set QWebKitTest::isScalable default as false
Summary: [Qt][WK2] Set QWebKitTest::isScalable default as false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 07:59 PDT by Dinu Jacob
Modified: 2012-12-04 02:37 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.17 KB, patch)
2012-06-01 08:03 PDT, Dinu Jacob 		vestbo: review+
Details | Formatted Diff | Diff
Patch for landing (1.17 KB, patch)
2012-06-01 08:57 PDT, Dinu Jacob 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dinu Jacob 2012-06-01 07:59:30 PDT 
Set QWebKitTest::isScalable default as false as per https://bugs.webkit.org/show_bug.cgi?id=87999#c4
Comment 1 Dinu Jacob 2012-06-01 08:03:38 PDT 
Created attachment 145308 [details]
Patch
Comment 2 Andras Becsi 2012-06-01 08:24:54 PDT 
Comment on attachment 145308 [details]
Patch

LGTM.
Comment 3 Tor Arne Vestbø 2012-06-01 08:27:03 PDT 
Comment on attachment 145308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145308&action=review

r=me with comment

> Source/WebKit2/ChangeLog:8
> +       Set QWebKitTest::isScalable default as false

indentation issue
Comment 4 Dinu Jacob 2012-06-01 08:57:46 PDT 
Created attachment 145320 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-06-01 09:51:14 PDT 
Comment on attachment 145320 [details]
Patch for landing

Clearing flags on attachment: 145320

Committed r119245: <http://trac.webkit.org/changeset/119245>
Comment 6 Michael Brüning 2012-07-12 02:20:12 PDT 
Hi Dinu, it seems that the patch has landed. Can this bug be closed?
Comment 7 Michael Brüning 2012-12-04 02:37:58 PST 
Issue is resolved, so I am closing this.