Bug 88081 - Web Inspector: add unknown size to the memory pie-chart legend
Summary: Web Inspector: add unknown size to the memory pie-chart legend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 87262
  Show dependency treegraph
 
Reported: 2012-06-01 05:45 PDT by Yury Semikhatsky
Modified: 2012-06-04 05:02 PDT (History)
10 users (show)

See Also:


Attachments
Patch (5.89 KB, patch)
2012-06-01 05:46 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (6.01 KB, patch)
2012-06-01 06:12 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-06-01 05:45:01 PDT
We only show total size and all known parts, unknown part should also be presented.
Comment 1 Yury Semikhatsky 2012-06-01 05:46:18 PDT
Created attachment 145278 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-06-01 06:02:42 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=145278&action=review

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:105
> +                memoryBlock.children.push({
> +                    name: "Unknown",
> +                    size: memoryBlock.size - knownSize

I think it is not necessary to add 'unknown' memory block if unknown size is equal to 0.
Comment 3 Yury Semikhatsky 2012-06-01 06:12:13 PDT
Created attachment 145286 [details]
Patch
Comment 4 Yury Semikhatsky 2012-06-01 06:12:33 PDT
(In reply to comment #2)
> View in context: https://bugs.webkit.org/attachment.cgi?id=145278&action=review
> 
> > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:105
> > +                memoryBlock.children.push({
> > +                    name: "Unknown",
> > +                    size: memoryBlock.size - knownSize
> 
> I think it is not necessary to add 'unknown' memory block if unknown size is equal to 0.

Done.
Comment 5 Ilya Tikhonovsky 2012-06-04 05:02:36 PDT
Comment on attachment 145286 [details]
Patch

Clearing flags on attachment: 145286

Committed r119386: <http://trac.webkit.org/changeset/119386>
Comment 6 Ilya Tikhonovsky 2012-06-04 05:02:44 PDT
All reviewed patches have been landed.  Closing bug.