Bug 88071 - [BlackBerry] Add end editing handling into AutofillManager
Summary: [BlackBerry] Add end editing handling into AutofillManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 03:28 PDT by Jonathan Dong
Modified: 2012-06-01 09:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.74 KB, patch)
2012-06-01 03:44 PDT, Jonathan Dong 		no flags Details | Formatted Diff | Diff
Patch (5.77 KB, patch)
2012-06-01 07:21 PDT, Jonathan Dong 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-06-01 03:28:32 PDT 
RIM PR: 106857

When user stops editing the input text field, we should notify AutofillManager to notify webpage to cancel the autofill dialog in browser. So we need to add the sccociated handling functions into AutofillManager, WebPagePrivate and WebPageClient.
Comment 1 Jonathan Dong 2012-06-01 03:44:40 PDT 
Created attachment 145261 [details]
Patch
Comment 2 Rob Buis 2012-06-01 04:13:30 PDT 
Comment on attachment 145261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145261&action=review

Looks good.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:44
> +    void didEndEditing(HTMLInputElement*);

Since other methods use TextField in the name, and we call it from  EditorClientBlackBerry::textFieldDidEndEditing, you should probably add TextField in this function too.
Comment 3 Jonathan Dong 2012-06-01 07:21:28 PDT 
Created attachment 145303 [details]
Patch
Comment 4 WebKit Review Bot 2012-06-01 09:00:35 PDT 
Comment on attachment 145303 [details]
Patch

Clearing flags on attachment: 145303

Committed r119239: <http://trac.webkit.org/changeset/119239>
Comment 5 WebKit Review Bot 2012-06-01 09:00:40 PDT 
All reviewed patches have been landed.  Closing bug.