Bug 88065 – [BlackBerry] IndexedDB file should be sand-boxed to the application data directory.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Charles Wei]

1. The IndexedDB now is only enabled for in-memory levelDB,  we should make it file system persistent.
2.  The directory should be sandboxes at the application data directory, with each security origin has its own sand-boxed directory.

[Charles Wei]

Created attachment 145247 [details]
Patch

[Rob Buis]

Comment on attachment 145247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145247&action=review

> Source/WebCore/Modules/indexeddb/IDBFactory.cpp:102
> +        m_backend->open(name, request.get(), context->securityOrigin(), frame, String(BlackBerry::Platform::Client::get()->getApplicationDataDirectory().c_str()));

Is it possible to put get dataDir in a port specific section? So if dataDir is empty we call BlackBerry::Platform::Client::get()->getApplicationDataDirectory()? Or is there nothing port specific?

[Charles Wei]

Comment on attachment 145247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145247&action=review

>> Source/WebCore/Modules/indexeddb/IDBFactory.cpp:102
>> +        m_backend->open(name, request.get(), context->securityOrigin(), frame, String(BlackBerry::Platform::Client::get()->getApplicationDataDirectory().c_str()));
> 
> Is it possible to put get dataDir in a port specific section? So if dataDir is empty we call BlackBerry::Platform::Client::get()->getApplicationDataDirectory()? Or is there nothing port specific?

Yes, we should make that at a port specific section. I'll try with another patch. Thanks.

[Charles Wei]

Created attachment 145909 [details]
Patch

[WebKit Review Bot]

Comment on attachment 145909 [details]
Patch

Clearing flags on attachment: 145909

Committed r119566: <http://trac.webkit.org/changeset/119566>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.