Bug 88065 - [BlackBerry] IndexedDB file should be sand-boxed to the application data directory.
Summary: [BlackBerry] IndexedDB file should be sand-boxed to the application data dire...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 02:30 PDT by Charles Wei
Modified: 2012-06-06 00:01 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.91 KB, patch)
2012-06-01 02:36 PDT, Charles Wei
no flags Details | Formatted Diff | Diff
Patch (3.78 KB, patch)
2012-06-05 18:13 PDT, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-06-01 02:30:45 PDT
1. The IndexedDB now is only enabled for in-memory levelDB,  we should make it file system persistent.
2.  The directory should be sandboxes at the application data directory, with each security origin has its own sand-boxed directory.
Comment 1 Charles Wei 2012-06-01 02:36:15 PDT
Created attachment 145247 [details]
Patch
Comment 2 Rob Buis 2012-06-01 07:08:35 PDT
Comment on attachment 145247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145247&action=review

> Source/WebCore/Modules/indexeddb/IDBFactory.cpp:102
> +        m_backend->open(name, request.get(), context->securityOrigin(), frame, String(BlackBerry::Platform::Client::get()->getApplicationDataDirectory().c_str()));

Is it possible to put get dataDir in a port specific section? So if dataDir is empty we call BlackBerry::Platform::Client::get()->getApplicationDataDirectory()? Or is there nothing port specific?
Comment 3 Charles Wei 2012-06-01 08:22:20 PDT
Comment on attachment 145247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145247&action=review

>> Source/WebCore/Modules/indexeddb/IDBFactory.cpp:102
>> +        m_backend->open(name, request.get(), context->securityOrigin(), frame, String(BlackBerry::Platform::Client::get()->getApplicationDataDirectory().c_str()));
> 
> Is it possible to put get dataDir in a port specific section? So if dataDir is empty we call BlackBerry::Platform::Client::get()->getApplicationDataDirectory()? Or is there nothing port specific?

Yes, we should make that at a port specific section. I'll try with another patch. Thanks.
Comment 4 Charles Wei 2012-06-05 18:13:47 PDT
Created attachment 145909 [details]
Patch
Comment 5 WebKit Review Bot 2012-06-06 00:01:34 PDT
Comment on attachment 145909 [details]
Patch

Clearing flags on attachment: 145909

Committed r119566: <http://trac.webkit.org/changeset/119566>
Comment 6 WebKit Review Bot 2012-06-06 00:01:42 PDT
All reviewed patches have been landed.  Closing bug.