Bug 88063 – Cleanup GeneratorGeneratedImage/Gradient changes from http://trac.webkit.org/changeset/117858

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Tim Horton]

There are a bunch of review comments from http://trac.webkit.org/changeset/117858 (in https://bugs.webkit.org/show_bug.cgi?id=86906) which I haven't yet taken care of. I have a patch to fix all but one (we still have a timer-per-GeneratorGeneratedImage) of the comments.

[Tim Horton]

Created attachment 145238 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 145238 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145238&action=review

> Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:65
>  
> -    if (!m_cachedImageBuffer
> -        || m_cachedGeneratorHash != generatorHash
> -        || m_cachedAdjustedSize != adjustedSize
> -        || !destContext->isCompatibleWithBuffer(m_cachedImageBuffer.get())) {
> -        // Create a BitmapImage and call drawPattern on it.
> +    if (!m_cachedImageBuffer || m_cachedGeneratorHash != generatorHash || m_cachedAdjustedSize != adjustedSize || !destContext->isCompatibleWithBuffer(m_cachedImageBuffer.get())) {

If the patch to draw() has been checked in by now, that will need the same cleanup.

> Source/WebCore/platform/graphics/GraphicsContext.cpp:767
> +    if (a.xScale() != b.xScale() || a.yScale() != b.yScale())
> +        return false;

return a.xScale() == b.xScale() && a.yScale() == b.yScale()?

[Tim Horton]

http://trac.webkit.org/changeset/119307