Bug 88063 - Cleanup GeneratorGeneratedImage/Gradient changes from http://trac.webkit.org/changeset/117858
Summary: Cleanup GeneratorGeneratedImage/Gradient changes from http://trac.webkit.org/...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 01:22 PDT by Tim Horton
Modified: 2012-06-01 18:39 PDT (History)
3 users (show)

See Also:


Attachments
patch (11.77 KB, patch)
2012-06-01 01:23 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-06-01 01:22:00 PDT
There are a bunch of review comments from http://trac.webkit.org/changeset/117858 (in https://bugs.webkit.org/show_bug.cgi?id=86906) which I haven't yet taken care of. I have a patch to fix all but one (we still have a timer-per-GeneratorGeneratedImage) of the comments.
Comment 1 Tim Horton 2012-06-01 01:23:33 PDT
Created attachment 145238 [details]
patch
Comment 2 Simon Fraser (smfr) 2012-06-01 08:24:29 PDT
Comment on attachment 145238 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145238&action=review

> Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:65
>  
> -    if (!m_cachedImageBuffer
> -        || m_cachedGeneratorHash != generatorHash
> -        || m_cachedAdjustedSize != adjustedSize
> -        || !destContext->isCompatibleWithBuffer(m_cachedImageBuffer.get())) {
> -        // Create a BitmapImage and call drawPattern on it.
> +    if (!m_cachedImageBuffer || m_cachedGeneratorHash != generatorHash || m_cachedAdjustedSize != adjustedSize || !destContext->isCompatibleWithBuffer(m_cachedImageBuffer.get())) {

If the patch to draw() has been checked in by now, that will need the same cleanup.

> Source/WebCore/platform/graphics/GraphicsContext.cpp:767
> +    if (a.xScale() != b.xScale() || a.yScale() != b.yScale())
> +        return false;

return a.xScale() == b.xScale() && a.yScale() == b.yScale()?
Comment 3 Tim Horton 2012-06-01 18:39:06 PDT
http://trac.webkit.org/changeset/119307