Bug 88057 - Overflow scrolling doesn't need to create a stacking context is the overflow is hidden
Summary: Overflow scrolling doesn't need to create a stacking context is the overflow ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency tree / graph
 
Reported: 2012-06-01 00:43 PDT by Adam Barth
Modified: 2012-06-01 15:54 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2012-06-01 00:44 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (1.30 KB, patch)
2012-06-01 13:41 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-06-01 00:43:46 PDT 
Overflow scrolling doesn't need to create a stacking context is the overflow is hidden
Comment 1 Adam Barth 2012-06-01 00:44:14 PDT 
Created attachment 145230 [details]
Patch
Comment 2 Adam Barth 2012-06-01 00:45:02 PDT 
This patch is in the chromium-android branch, but I'm unsure whether it's correct.  If it's correct, I'd appreciate any pointers towards how to create a test for this change.

Thanks!
Comment 3 WebKit Review Bot 2012-06-01 00:47:25 PDT 
Attachment 145230 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Sami Kyostila 2012-06-01 09:36:54 PDT 
I think the change makes sense, but we should check that it matches the iOS5 implementation.
Comment 5 Adam Barth 2012-06-01 09:42:53 PDT 
(In reply to comment #4)
> I think the change makes sense, but we should check that it matches the iOS5 implementation.

Is there an easy way I can check that with my iPad?
Comment 7 Adam Barth 2012-06-01 10:56:44 PDT 
Thanks James.
Comment 8 Adam Barth 2012-06-01 13:41:39 PDT 
Created attachment 145372 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-06-01 15:54:11 PDT 
Comment on attachment 145372 [details]
Patch for landing

Clearing flags on attachment: 145372

Committed r119294: <http://trac.webkit.org/changeset/119294>
Comment 10 WebKit Review Bot 2012-06-01 15:54:16 PDT 
All reviewed patches have been landed.  Closing bug.