Bug 88038 - [Chromium] Call clipboard methods directly
Summary: [Chromium] Call clipboard methods directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
: 88037 (view as bug list)
Depends on:
Blocks: 82948
  Show dependency treegraph
 
Reported: 2012-05-31 19:49 PDT by Mark Pilgrim (Google)
Modified: 2012-06-01 11:55 PDT (History)
7 users (show)

See Also:


Attachments
Patch (24.94 KB, patch)
2012-05-31 19:50 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (26.21 KB, patch)
2012-06-01 06:34 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-31 19:49:59 PDT
[Chromium] Call clipboard methods directly
Comment 1 Mark Pilgrim (Google) 2012-05-31 19:50:35 PDT
Created attachment 145200 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-05-31 19:51:07 PDT
*** Bug 88037 has been marked as a duplicate of this bug. ***
Comment 3 WebKit Review Bot 2012-05-31 19:52:25 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Adam Barth 2012-05-31 22:12:00 PDT
Comment on attachment 145200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145200&action=review

> Source/Platform/chromium/public/WebClipboard.h:65
> -    virtual uint64 sequenceNumber(Buffer) { return 0; }
> +    virtual uint64_t sequenceNumber(Buffer) { return 0; }

I'm surprised this change is needed, but it seems harmless.
Comment 5 WebKit Review Bot 2012-06-01 00:06:46 PDT
Comment on attachment 145200 [details]
Patch

Attachment 145200 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12873182
Comment 6 Mark Pilgrim (Google) 2012-06-01 06:34:10 PDT
Created attachment 145290 [details]
Patch
Comment 7 Mark Pilgrim (Google) 2012-06-01 06:34:42 PDT
Comment on attachment 145290 [details]
Patch

Updated GYPI file.
Comment 8 WebKit Review Bot 2012-06-01 11:55:47 PDT
Comment on attachment 145290 [details]
Patch

Clearing flags on attachment: 145290

Committed r119258: <http://trac.webkit.org/changeset/119258>
Comment 9 WebKit Review Bot 2012-06-01 11:55:53 PDT
All reviewed patches have been landed.  Closing bug.