Bug 88029 - content-element-api.html and shadow-element.html depend on V8
Summary: content-element-api.html and shadow-element.html depend on V8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 87732
  Show dependency treegraph
 
Reported: 2012-05-31 17:28 PDT by Hajime Morrita
Modified: 2012-06-05 04:28 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.16 KB, patch)
2012-05-31 17:47 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-02 (530.98 KB, application/zip)
2012-05-31 18:40 PDT, WebKit Review Bot
no flags Details
Patch for landing (3.62 KB, patch)
2012-06-05 03:15 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-05-31 17:28:49 PDT
It could be portable between V8 and JSC. (Based on the feedback at Bug 86859)
Comment 1 Hajime Morrita 2012-05-31 17:47:33 PDT
Created attachment 145181 [details]
Patch
Comment 2 Kentaro Hara 2012-05-31 17:48:06 PDT
Comment on attachment 145181 [details]
Patch

Looks OK
Comment 3 WebKit Review Bot 2012-05-31 18:40:46 PDT
Comment on attachment 145181 [details]
Patch

Rejecting attachment 145181 [details] from commit-queue.

New failing tests:
fast/dom/shadow/content-element-api.html
fast/dom/shadow/shadow-element.html
Full output: http://queues.webkit.org/results/12862445
Comment 4 WebKit Review Bot 2012-05-31 18:40:49 PDT
Created attachment 145190 [details]
Archive of layout-test-results from ec2-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Chris Dumez 2012-06-03 22:43:14 PDT
Could we get this one fixed/committed please?
Comment 6 Chris Dumez 2012-06-03 22:52:30 PDT
Comment on attachment 145181 [details]
Patch

I believe you forgot to update the expected results.
Comment 7 Kentaro Hara 2012-06-03 22:57:14 PDT
(In reply to comment #6)
> (From update of attachment 145181 [details])
> I believe you forgot to update the expected results.

Yeah. morrita: would you update the results and land the patch?
Comment 8 Hajime Morrita 2012-06-04 19:04:56 PDT
> Yeah. morrita: would you update the results and land the patch?

oops. thanks for the reminder. will do.
Comment 9 Hajime Morrita 2012-06-05 03:15:20 PDT
Created attachment 145743 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-06-05 04:28:41 PDT
Comment on attachment 145743 [details]
Patch for landing

Clearing flags on attachment: 145743

Committed r119481: <http://trac.webkit.org/changeset/119481>
Comment 11 WebKit Review Bot 2012-06-05 04:28:46 PDT
All reviewed patches have been landed.  Closing bug.