Bug 87977 - [Qt] Clean up our viewport handling mess
Summary: [Qt] Clean up our viewport handling mess
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
Depends on:
Reported: 2012-05-31 07:49 PDT by Kenneth Rohde Christiansen
Modified: 2012-06-01 04:14 PDT (History)
6 users (show)

See Also:

Patch (20.09 KB, patch)
2012-05-31 07:50 PDT, Kenneth Rohde Christiansen
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2012-05-31 07:49:35 PDT
Consolidated functionality from QQuickWebViewPrivate* into ViewportInteractionEngine that belongs there, in preparation for renaming ViewportInteractionEngine in the future.
Comment 1 Kenneth Rohde Christiansen 2012-05-31 07:50:28 PDT
Created attachment 145092 [details]
Comment 2 Andras Becsi 2012-05-31 08:38:48 PDT
Comment on attachment 145092 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=145092&action=review

The patch looks generally good to me.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:858
> +    // FIXME: Examine why there is not an interactionEngine here in the beginning.

The interactionEngine is created when the WebView component is completed in QQuickWebViewFlickablePrivate::onComponentComplete().
This mainly has historical reasons but it also reduces updates on startup.
Comment 3 Kenneth Rohde Christiansen 2012-06-01 04:14:29 PDT
Landed in 119210