Bug 87975 - Web Inspector: [JSC] Add WebGL instrumentation support
Summary: Web Inspector: [JSC] Add WebGL instrumentation support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on: 87960
Blocks: 87959
  Show dependency treegraph
 
Reported: 2012-05-31 07:44 PDT by Andrey Adaikin
Modified: 2012-06-06 07:13 PDT (History)
17 users (show)

See Also:


Attachments
Patch (3.13 KB, patch)
2012-06-06 02:07 PDT, Andrey Adaikin
no flags Details | Formatted Diff | Diff
Patch (9.02 KB, patch)
2012-06-06 04:34 PDT, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-05-31 07:44:26 PDT
FIXME at Source/WebCore/bindings/js/JSInjectedScriptManager.cpp
Comment 1 Andrey Adaikin 2012-06-06 02:07:33 PDT
Created attachment 145965 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-06-06 04:02:50 PDT
Comment on attachment 145965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145965&action=review

> Source/WebCore/bindings/js/JSInjectedScriptManager.cpp:91
> +ScriptObject InjectedScriptManager::injectWebGLScript(const String& source, ScriptObject glContext)

You should pass ScriptObject by reference (both here and in v8).
Comment 3 Andrey Adaikin 2012-06-06 04:34:21 PDT
Created attachment 145990 [details]
Patch
Comment 4 Andrey Kosyakov 2012-06-06 07:12:51 PDT
Comment on attachment 145990 [details]
Patch

Clearing flags on attachment: 145990

Committed r119589: <http://trac.webkit.org/changeset/119589>
Comment 5 Andrey Kosyakov 2012-06-06 07:13:09 PDT
All reviewed patches have been landed.  Closing bug.