Bug 87971 - Web Inspector: add RenderArena sizes to the memory pie-chart
Summary: Web Inspector: add RenderArena sizes to the memory pie-chart
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on: 87984
Blocks: 87262
  Show dependency treegraph
 
Reported: 2012-05-31 07:21 PDT by Yury Semikhatsky
Modified: 2012-06-01 01:35 PDT (History)
11 users (show)

See Also:


Attachments
Patch (4.41 KB, patch)
2012-05-31 07:24 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2012-05-31 07:29 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-05-31 07:21:17 PDT
It can be easily measured and may well represent a considerable part of memory on some pages.
Comment 1 Yury Semikhatsky 2012-05-31 07:24:04 PDT
Created attachment 145087 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-31 07:29:11 PDT
Created attachment 145088 [details]
Patch
Comment 3 Ilya Tikhonovsky 2012-05-31 07:39:58 PDT
Comment on attachment 145088 [details]
Patch

looks good to me
Comment 4 Pavel Feldman 2012-06-01 01:12:06 PDT
Comment on attachment 145088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145088&action=review

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:342
> +

I leke the vertical builder code layout better.
Comment 5 Yury Semikhatsky 2012-06-01 01:35:12 PDT
Committed r119201: <http://trac.webkit.org/changeset/119201>