Bug 87955 - [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
Summary: [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tor Arne Vestbø
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-31 04:51 PDT by Tor Arne Vestbø
Modified: 2012-05-31 07:01 PDT (History)
9 users (show)

See Also:

Attachments
Patch (40.47 KB, patch)
2012-05-31 04:53 PDT, Tor Arne Vestbø 		no flags Details | Formatted Diff | Diff
Patch (41.54 KB, patch)
2012-05-31 05:55 PDT, Tor Arne Vestbø 		no flags Details | Formatted Diff | Diff
Patch (41.58 KB, patch)
2012-05-31 06:17 PDT, Tor Arne Vestbø 		hausmann: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tor Arne Vestbø 2012-05-31 04:51:54 PDT 
[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
Comment 1 Tor Arne Vestbø 2012-05-31 04:53:39 PDT 
Created attachment 145051 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-31 04:56:21 PDT 
Attachment 145051 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/qt..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2012-05-31 05:06:27 PDT 
Comment on attachment 145051 [details]
Patch

Attachment 145051 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12866198
Comment 4 Early Warning System Bot 2012-05-31 05:09:21 PDT 
Comment on attachment 145051 [details]
Patch

Attachment 145051 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12859322
Comment 5 Tor Arne Vestbø 2012-05-31 05:55:43 PDT 
Created attachment 145065 [details]
Patch

Fixed missing config.h includes and use of HAVE macro in moc'ed headers
Comment 6 Tor Arne Vestbø 2012-05-31 06:17:46 PDT 
Created attachment 145073 [details]
Patch

Fix one last missing moc'ed header
Comment 7 Tor Arne Vestbø 2012-05-31 07:01:15 PDT 
Committed r119098: <http://trac.webkit.org/changeset/119098>