Bug 87944 - WebCore fails to compile with SVG disabled.
Summary: WebCore fails to compile with SVG disabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-31 02:26 PDT by Mike West
Modified: 2012-05-31 05:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.16 KB, patch)
2012-05-31 02:29 PDT, Mike West 		no flags Details | Formatted Diff | Diff
Patch (2.15 KB, patch)
2012-05-31 02:38 PDT, Mike West 		no flags Details | Formatted Diff | Diff
Patch (2.14 KB, patch)
2012-05-31 02:46 PDT, Mike West 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2012-05-31 02:26:23 PDT 
The Chromium port fails to compile on linux w/ ninja/clang:

../../Source/WebCore/css/StyleResolver.cpp:3183:13: error: enumeration value 'CSSPropertyWebkitBoxDecorationBreak' not handled in switch [-Werror,-Wswitch]
    switch (id) {

../../Source/WebCore/css/CSSParser.cpp:1521:13: error: enumeration value 'CSSPropertyWebkitBoxDecorationBreak' not handled in switch [-Werror,-Wswitch]
    switch (propId) {

Looks like this started after https://bugs.webkit.org/show_bug.cgi?id=87678 landed r118853.
Comment 1 Mike West 2012-05-31 02:29:22 PDT 
Created attachment 145023 [details]
Patch
Comment 2 jochen 2012-05-31 02:32:40 PDT 
Comment on attachment 145023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145023&action=review

> Source/WebCore/ChangeLog:3
> +        Chromium port fails to compile on linux w/ ninja/clang

The patch looks good, but the changelog is incorrect. It's not Chromium ninja/clang that is the problem, but you try to compile with SVG disabled. If it's enabled, the switch statement has a default: branch, and so the compilers don't catch the missing enum value
Comment 3 Mike West 2012-05-31 02:38:36 PDT 
Created attachment 145025 [details]
Patch
Comment 4 Mike West 2012-05-31 02:39:16 PDT 
Thanks Jochen, that makes much more sense. I've updated the ChangeLog, and I'll head to IRC to find a reviewer.
Comment 5 jochen 2012-05-31 02:42:21 PDT 
Comment on attachment 145025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145025&action=review

> Source/WebCore/ChangeLog:3
> +        [Chromium] Fixing compilation with SVG disabled.

plz drop the [chromium], this affects all ports
Comment 6 Mike West 2012-05-31 02:46:00 PDT 
Created attachment 145028 [details]
Patch
Comment 7 Mike West 2012-05-31 02:46:35 PDT 
Ah. Right. Done.
Comment 8 WebKit Review Bot 2012-05-31 05:41:27 PDT 
Comment on attachment 145028 [details]
Patch

Clearing flags on attachment: 145028

Committed r119094: <http://trac.webkit.org/changeset/119094>
Comment 9 WebKit Review Bot 2012-05-31 05:41:32 PDT 
All reviewed patches have been landed.  Closing bug.