WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87941
[Platform] Implementation of Decimal(int32_t) isn't portable.
https://bugs.webkit.org/show_bug.cgi?id=87941
Summary
[Platform] Implementation of Decimal(int32_t) isn't portable.
yosin
Reported
2012-05-31 01:35:32 PDT
The value of expression (i32 < 0 ? -i32 : i32) is undefined when i32 = std::numeric_limits<int32_t>::min(), e.g. 0x80000000.
Attachments
Patch 1
(1.56 KB, patch)
2012-05-31 02:04 PDT
,
yosin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
yosin
Comment 1
2012-05-31 02:04:42 PDT
Created
attachment 145021
[details]
Patch 1
yosin
Comment 2
2012-05-31 02:05:41 PDT
Comment on
attachment 145021
[details]
Patch 1 Could you review this patch? Thanks in advance. -yosi
Kent Tamura
Comment 3
2012-05-31 02:06:20 PDT
Comment on
attachment 145021
[details]
Patch 1 ok
WebKit Review Bot
Comment 4
2012-05-31 04:54:36 PDT
Comment on
attachment 145021
[details]
Patch 1 Clearing flags on attachment: 145021 Committed
r119088
: <
http://trac.webkit.org/changeset/119088
>
WebKit Review Bot
Comment 5
2012-05-31 04:54:40 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug