Bug 87941 - [Platform] Implementation of Decimal(int32_t) isn't portable.
Summary: [Platform] Implementation of Decimal(int32_t) isn't portable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 80009
  Show dependency treegraph
 
Reported: 2012-05-31 01:35 PDT by yosin
Modified: 2012-05-31 04:54 PDT (History)
2 users (show)

See Also:


Attachments
Patch 1 (1.56 KB, patch)
2012-05-31 02:04 PDT, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-05-31 01:35:32 PDT
The value of expression (i32 < 0 ? -i32 : i32) is undefined when i32 = std::numeric_limits<int32_t>::min(), e.g. 0x80000000.
Comment 1 yosin 2012-05-31 02:04:42 PDT
Created attachment 145021 [details]
Patch 1
Comment 2 yosin 2012-05-31 02:05:41 PDT
Comment on attachment 145021 [details]
Patch 1

Could you review this patch?
Thanks in advance.
-yosi
Comment 3 Kent Tamura 2012-05-31 02:06:20 PDT
Comment on attachment 145021 [details]
Patch 1

ok
Comment 4 WebKit Review Bot 2012-05-31 04:54:36 PDT
Comment on attachment 145021 [details]
Patch 1

Clearing flags on attachment: 145021

Committed r119088: <http://trac.webkit.org/changeset/119088>
Comment 5 WebKit Review Bot 2012-05-31 04:54:40 PDT
All reviewed patches have been landed.  Closing bug.