RESOLVED FIXED 87939
Syntax error in fast/filesystem/resources/file-writer-gc-blob.js 
https://bugs.webkit.org/show_bug.cgi?id=87939
Summary Syntax error in fast/filesystem/resources/file-writer-gc-blob.js
Leo Yang
Reported 2012-05-31 01:16:18 PDT
var blob = tenXBlob(new Blob["lorem ipsum"]); <-- parentheses are missed around [].
Attachments
Patch (1.81 KB, patch)
2012-05-31 01:20 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-05-31 01:20:34 PDT
Created attachment 145016 [details] Patch
Alexey Proskuryakov
Comment 2 2012-05-31 10:17:47 PDT
What effect does this have on test results?
Leo Yang
Comment 3 2012-05-31 18:44:26 PDT
(In reply to comment #2) > What effect does this have on test results? JSC generates something like: Type Error: "undefined" is not a constructor. Apparently Blob["lorem ipsum"] is undefined. You might ask why this case passes. I would say all portings except for chromium that uses v8 don't support filesystem API so they don't run this case. The BlackBerry porting is implementing filesystem API with JSC. This case will fail using JSC.
Alexey Proskuryakov
Comment 4 2012-05-31 22:41:59 PDT
Makes sense. What about chromium - why doesn't the test fail there? It looks like a v8 bindings bug if Blob["lorem ipsum"] === Blob.
Leo Yang
Comment 5 2012-05-31 23:00:59 PDT
(In reply to comment #4) > Makes sense. What about chromium - why doesn't the test fail there? It looks like a v8 bindings bug if Blob["lorem ipsum"] === Blob. I have no idea why there is no error for v8. The fix is harmless for v8 since the cr-linux ews bot is green. IIRC, cr-linux ews bot will run layout tests.
Kentaro Hara
Comment 6 2012-06-04 20:55:16 PDT
(In reply to comment #5) > (In reply to comment #4) > I have no idea why there is no error for v8. The fix is harmless for v8 since the cr-linux ews bot is green. IIRC, cr-linux ews bot will run layout tests. That's because file-writer-gc-blob.html is skipped in LayoutTests/platform/chromium/TestExpectations due to bug 85174.
Alexey Proskuryakov
Comment 7 2012-06-04 21:14:32 PDT
Comment on attachment 145016 [details] Patch Cool.
WebKit Review Bot
Comment 8 2012-06-04 21:29:49 PDT
Comment on attachment 145016 [details] Patch Clearing flags on attachment: 145016 Committed r119454: <http://trac.webkit.org/changeset/119454>
WebKit Review Bot
Comment 9 2012-06-04 21:29:54 PDT
All reviewed patches have been landed. Closing bug.
Kinuko Yasuda
Comment 10 2012-06-05 06:18:00 PDT
Ah I just noticed this fix. Thanks for fixing!
Note You need to log in before you can comment on or make changes to this bug.