Bug 87936 - [Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls.
Summary: [Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisib...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
: 88004 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-05-31 00:50 PDT by zalan
Modified: 2012-05-31 18:37 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2012-05-31 01:05 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2012-05-31 05:02 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2012-05-31 00:50:59 PDT
SSIA
Comment 1 zalan 2012-05-31 01:05:28 PDT
Created attachment 145011 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-05-31 01:50:02 PDT
Comment on attachment 145011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145011&action=review

> Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:345
>  void QtViewportInteractionEngine::scaleAnimationValueChanged(QVariant value)
>  {
> +    ViewportUpdateDeferrer guard(this);
>      setPageItemRectVisible(value.toRectF());
>  }

This one is not needed... it should be guarded already
Comment 3 zalan 2012-05-31 04:45:37 PDT
(In reply to comment #2)
> (From update of attachment 145011 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145011&action=review
> 
> > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:345
> >  void QtViewportInteractionEngine::scaleAnimationValueChanged(QVariant value)
> >  {
> > +    ViewportUpdateDeferrer guard(this);
> >      setPageItemRectVisible(value.toRectF());
> >  }
> 
> This one is not needed... it should be guarded already

Good catch, but unfortunately it is not guarded. Created a new bug report on that bug#87954
Comment 4 zalan 2012-05-31 05:02:20 PDT
Created attachment 145052 [details]
Patch
Comment 5 WebKit Review Bot 2012-05-31 06:07:51 PDT
Comment on attachment 145052 [details]
Patch

Clearing flags on attachment: 145052

Committed r119095: <http://trac.webkit.org/changeset/119095>
Comment 6 WebKit Review Bot 2012-05-31 06:07:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Dinu Jacob 2012-05-31 18:37:30 PDT
*** Bug 88004 has been marked as a duplicate of this bug. ***