WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87933
Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merely relies on PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=87933
Summary
Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that whi...
Andy Estes
Reported
2012-05-31 00:39:25 PDT
Guard automatic text replacement code with WTF_USE_AUTOMATIC_TEXT_REPLACEMENT rather than WTF_PLATFORM_MAC
Attachments
Patch
(11.55 KB, patch)
2012-05-31 00:41 PDT
,
Andy Estes
no flags
Details
Formatted Diff
Diff
Patch
(10.64 KB, patch)
2012-05-31 13:48 PDT
,
Andy Estes
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andy Estes
Comment 1
2012-05-31 00:41:05 PDT
Created
attachment 145006
[details]
Patch
Andy Estes
Comment 2
2012-05-31 01:00:10 PDT
Comment on
attachment 145006
[details]
Patch This went too far.
Andy Estes
Comment 3
2012-05-31 13:48:09 PDT
Created
attachment 145149
[details]
Patch
mitz
Comment 4
2012-05-31 13:51:47 PDT
Comment on
attachment 145149
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=145149&action=review
> Source/WebCore/ChangeLog:3 > + Guard automatic text replacement code with WTF_USE_AUTOMATIC_TEXT_REPLACEMENT rather than WTF_PLATFORM_MAC
This doesn’t quite describe what the patch ended up doing.
Andy Estes
Comment 5
2012-05-31 14:03:23 PDT
Committed
r119145
: <
http://trac.webkit.org/changeset/119145
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug