Bug 87933 - Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merely relies on PLATFORM(MAC)
Summary: Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that whi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-31 00:39 PDT by Andy Estes
Modified: 2012-05-31 14:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (11.55 KB, patch)
2012-05-31 00:41 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (10.64 KB, patch)
2012-05-31 13:48 PDT, Andy Estes
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2012-05-31 00:39:25 PDT
Guard automatic text replacement code with WTF_USE_AUTOMATIC_TEXT_REPLACEMENT rather than WTF_PLATFORM_MAC
Comment 1 Andy Estes 2012-05-31 00:41:05 PDT
Created attachment 145006 [details]
Patch
Comment 2 Andy Estes 2012-05-31 01:00:10 PDT
Comment on attachment 145006 [details]
Patch

This went too far.
Comment 3 Andy Estes 2012-05-31 13:48:09 PDT
Created attachment 145149 [details]
Patch
Comment 4 mitz 2012-05-31 13:51:47 PDT
Comment on attachment 145149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145149&action=review

> Source/WebCore/ChangeLog:3
> +        Guard automatic text replacement code with WTF_USE_AUTOMATIC_TEXT_REPLACEMENT rather than WTF_PLATFORM_MAC

This doesn’t quite describe what the patch ended up doing.
Comment 5 Andy Estes 2012-05-31 14:03:23 PDT
Committed r119145: <http://trac.webkit.org/changeset/119145>