Bug 87927 - [CMAKE][EFL] Remove unneeded include path
Summary: [CMAKE][EFL] Remove unneeded include path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-30 22:43 PDT by Gyuyoung Kim
Modified: 2012-05-31 03:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2012-05-30 22:46 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (3.03 KB, patch)
2012-05-31 02:30 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-05-30 22:43:33 PDT 
Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including previous path. In addition, Files on EFL port is using <wtf/gobject/XXX> directly in #include line. So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.
Comment 1 Gyuyoung Kim 2012-05-30 22:46:33 PDT 
Created attachment 144991 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-05-31 02:26:20 PDT 
Comment on attachment 144991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144991&action=review

> Source/WebCore/ChangeLog:8
> +        Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including previous

the previous

> Source/WebCore/ChangeLog:9
> +        path. In addition, Files on EFL port is using "<wtf/gobject/XXX>" directly in #include line.

Files *are* ... on the #include line.
Comment 3 Gyuyoung Kim 2012-05-31 02:30:38 PDT 
Created attachment 145024 [details]
Patch
Comment 4 WebKit Review Bot 2012-05-31 03:02:31 PDT 
Comment on attachment 145024 [details]
Patch

Clearing flags on attachment: 145024

Committed r119080: <http://trac.webkit.org/changeset/119080>
Comment 5 WebKit Review Bot 2012-05-31 03:02:42 PDT 
All reviewed patches have been landed.  Closing bug.