Bug 87922 – [Qt][WK2] Contents not rendered in MiniBrowser for some pages

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Dinu Jacob]

Contents are not rendered in MiniBrowser for some pages like google.com though the page has been loaded successfully

[Dinu Jacob]

For these pages the comparison between accurateVisibleRect and drawing area contentsRect in QQuickWebViewFlickablePrivate::_q_onInformVisibleContentChange is true.
drawingArea->contentsRect is actually returning the contentsSize and this is set by the time we reach this slot. Thus the drawing area visible contents rect is not set correctly. For pages with contents height greater than the viewport bounding rect height, it gets set when the content size grows beyond the viewport bounding rect height.

[Dinu Jacob]

Created attachment 144979 [details]
Patch

[Dinu Jacob]

Created attachment 145113 [details]
Patch

[Dinu Jacob]

Added a new patch that attempts to compare the actual visible contents rect of drawing area and the new value to determine early return in  _q_onInformVisibleContentChange.

[WebKit Review Bot]

Comment on attachment 145113 [details]
Patch

Attachment 145113 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12872265

New failing tests:
http/tests/media/media-source/video-media-source-event-attributes.html

[WebKit Review Bot]

Created attachment 145189 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Kenneth Rohde Christiansen]

Comment on attachment 145113 [details]
Patch

Please redo then when I commit my other patch. This is all changed.

[Dinu Jacob]

Created attachment 145275 [details]
Patch

[Andras Becsi]

Comment on attachment 145275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145275&action=review

LGTM.

> Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:696
> +    if (m_lastVisibleContentsRect == visibleContentsRect())
> +             return;
> +

Indentation.

[Kenneth Rohde Christiansen]

Comment on attachment 145275 [details]
Patch

r=me with fixed indentation

[Dinu Jacob]

Created attachment 145294 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 145294 [details]
Patch for landing

Clearing flags on attachment: 145294

Committed r119231: <http://trac.webkit.org/changeset/119231>

[Michael Brüning]

Should we close this bug? It seems all patches have landed and the issues are fixed.

[Michael Brüning]

This came up on the pending commit list sent around on Eric Seidel. The patch has landed and the issues have been fixed as far as I saw in a test, so I am closing this.