Bug 87921 – [chromium] Combobox options and autofill options should not be scaled for device-scale factor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Sadrul Habib Chowdhury]

Combobox options and autofill options should not be scaled for device-scale factor.

[Sadrul Habib Chowdhury]

Created attachment 144977 [details]
Patch

[Sadrul Habib Chowdhury]

(In reply to comment #1)
> Created an attachment (id=144977) [details]
> Patch

Just a quick note: this reverts parts of https://bugs.webkit.org/show_bug.cgi?id=80027

[Darin Fisher (:fishd, Google)]

What is the motivation for this change?  Why is it better to do this on the Chromium side?

[Sadrul Habib Chowdhury]

(In reply to comment #3)
> What is the motivation for this change?  Why is it better to do this on the Chromium side?

The scaling that is done for combobox/autofill popups do not work correctly for the other components. So a normal web-page does not paint correctly when device-scale-factor is larger than 1. At the same time, chrome does some scaling on the browser side, so this ends up scaling twice.

The proper fix is to set the scaling factor on the graphics-context (done in https://bugs.webkit.org/show_bug.cgi?id=88136, with corresponding changes on the chrome side in http://codereview.chromium.org/10451112/ and http://codereview.chromium.org/10481005/)

[WebKit Review Bot]

Comment on attachment 144977 [details]
Patch

Clearing flags on attachment: 144977

Committed r119420: <http://trac.webkit.org/changeset/119420>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.