Bug 87921 - [chromium] Combobox options and autofill options should not be scaled for device-scale factor
Summary: [chromium] Combobox options and autofill options should not be scaled for dev...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sadrul Habib Chowdhury
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-30 20:33 PDT by Sadrul Habib Chowdhury
Modified: 2012-06-04 12:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.79 KB, patch)
2012-05-30 20:35 PDT, Sadrul Habib Chowdhury 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sadrul Habib Chowdhury 2012-05-30 20:33:57 PDT 
Combobox options and autofill options should not be scaled for device-scale factor.
Comment 1 Sadrul Habib Chowdhury 2012-05-30 20:35:05 PDT 
Created attachment 144977 [details]
Patch
Comment 2 Sadrul Habib Chowdhury 2012-05-30 20:36:43 PDT 
(In reply to comment #1)
> Created an attachment (id=144977) [details]
> Patch

Just a quick note: this reverts parts of https://bugs.webkit.org/show_bug.cgi?id=80027
Comment 3 Darin Fisher (:fishd, Google) 2012-06-01 09:17:27 PDT 
What is the motivation for this change?  Why is it better to do this on the Chromium side?
Comment 4 Sadrul Habib Chowdhury 2012-06-04 12:23:11 PDT 
(In reply to comment #3)
> What is the motivation for this change?  Why is it better to do this on the Chromium side?

The scaling that is done for combobox/autofill popups do not work correctly for the other components. So a normal web-page does not paint correctly when device-scale-factor is larger than 1. At the same time, chrome does some scaling on the browser side, so this ends up scaling twice.

The proper fix is to set the scaling factor on the graphics-context (done in https://bugs.webkit.org/show_bug.cgi?id=88136, with corresponding changes on the chrome side in http://codereview.chromium.org/10451112/ and http://codereview.chromium.org/10481005/)
Comment 5 WebKit Review Bot 2012-06-04 12:56:51 PDT 
Comment on attachment 144977 [details]
Patch

Clearing flags on attachment: 144977

Committed r119420: <http://trac.webkit.org/changeset/119420>
Comment 6 WebKit Review Bot 2012-06-04 12:56:57 PDT 
All reviewed patches have been landed.  Closing bug.