Bug 87919 - [Win] Need implementation of layoutTestController.setBackingScaleFactor
Summary: [Win] Need implementation of layoutTestController.setBackingScaleFactor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Windows 7
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar, LayoutTestFailure
Depends on:
Blocks: 146335
  Show dependency tree / graph
 
Reported: 2012-05-30 20:22 PDT by Jessie Berlin
Modified: 2015-10-12 12:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.35 KB, patch)
2015-06-25 18:39 PDT, Brent Fulgham 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2012-05-30 20:22:38 PDT 
It was added as a stub to LayoutTestControllerWin.cpp in http://trac.webkit.org/changeset/97407 and never fleshed out.

In some ways, it would have been better to have omitted the stub on Windows, so it would be more obvious which tests use it and need to be Skipped on Windows
Comment 1 Radar WebKit Bug Importer 2012-05-30 20:23:00 PDT 
<rdar://problem/11563242>
Comment 2 Jessie Berlin 2012-05-30 20:30:27 PDT 
Added tests to the Windows Skipped list in http://trac.webkit.org/changeset/119039
Comment 3 Brent Fulgham 2015-06-25 18:39:29 PDT 
Created attachment 255608 [details]
Patch
Comment 4 Brent Fulgham 2015-06-25 18:59:13 PDT 
I'll unskip the tests Jessie skipped back in 2012 once the builders catch up and I can identify any minor differences due to font and other variations with Windows.
Comment 5 Brent Fulgham 2015-06-25 20:56:29 PDT 
Committed r185982: <http://trac.webkit.org/changeset/185982>
Comment 6 Brent Fulgham 2015-10-12 12:14:44 PDT 
The following tests now work properly:

fast/layers/hidpi-transform-on-child-content-is-mispositioned.html