Bug 87907 - rename flexbox CSS properties from flex-align and flex-item-align to align-items and align-self
Summary: rename flexbox CSS properties from flex-align and flex-item-align to align-it...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency tree / graph
 
Reported: 2012-05-30 16:05 PDT by Tony Chang
Modified: 2012-05-31 12:08 PDT (History)
7 users (show)

See Also:

Attachments
Patch (117.03 KB, patch)
2012-05-30 16:05 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch (119.50 KB, patch)
2012-05-30 16:14 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-03 (533.08 KB, application/zip)
2012-05-30 22:41 PDT, WebKit Review Bot 		no flags Details
Archive of layout-test-results from ec2-cr-linux-02 (518.36 KB, application/zip)
2012-05-30 22:45 PDT, WebKit Review Bot 		no flags Details
Patch for landing (170.38 KB, patch)
2012-05-31 10:09 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-05-30 16:05:07 PDT 
rename flexbox CSS properties from flex-align and flex-item-align to align-items and align-self
Comment 1 Tony Chang 2012-05-30 16:05:47 PDT 
Created attachment 144946 [details]
Patch
Comment 2 Tony Chang 2012-05-30 16:07:25 PDT 
Comment on attachment 144946 [details]
Patch

Just kidding. I still need to move the members in RenderStyle.
Comment 3 Tony Chang 2012-05-30 16:14:41 PDT 
Created attachment 144947 [details]
Patch
Comment 4 WebKit Review Bot 2012-05-30 22:41:00 PDT 
Comment on attachment 144947 [details]
Patch

Rejecting attachment 144947 [details] from commit-queue.

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
svg/css/getComputedStyle-basic.xhtml
Full output: http://queues.webkit.org/results/12859244
Comment 5 WebKit Review Bot 2012-05-30 22:41:04 PDT 
Created attachment 144989 [details]
Archive of layout-test-results from ec2-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 6 WebKit Review Bot 2012-05-30 22:45:41 PDT 
Comment on attachment 144947 [details]
Patch

Attachment 144947 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12869047

New failing tests:
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
svg/css/getComputedStyle-basic.xhtml
Comment 7 WebKit Review Bot 2012-05-30 22:45:45 PDT 
Created attachment 144990 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 8 Tony Chang 2012-05-31 10:09:01 PDT 
Created attachment 145111 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-05-31 12:08:40 PDT 
Comment on attachment 145111 [details]
Patch for landing

Clearing flags on attachment: 145111

Committed r119131: <http://trac.webkit.org/changeset/119131>
Comment 10 WebKit Review Bot 2012-05-31 12:08:45 PDT 
All reviewed patches have been landed.  Closing bug.