Bug 87902 - Add an helper function to get the style for a cell's flow computation
Summary: Add an helper function to get the style for a cell's flow computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 87900
  Show dependency tree / graph
 
Reported: 2012-05-30 14:53 PDT by Julien Chaffraix
Modified: 2012-05-30 20:15 PDT (History)
6 users (show)

See Also:

Attachments
Proposed addition: styleForCellFlow. (20.38 KB, patch)
2012-05-30 15:25 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-05-30 14:53:56 PDT 
Currently the code makes the assumption that we use the table's direction and writing mode for flow resolution.

While CSS writing disables writing mode on table row groups and rows, it does allow direction on the same table parts. This means that the current code makes the wrong assumption and will break pretty badly if we start mixing directions.

In order to change that, a first step would be to introduce an helper function to get the right style for flow resolution (flow = direction and writing mode). We can then safely change this function to operate on a different level.
Comment 1 Julien Chaffraix 2012-05-30 15:25:27 PDT 
Created attachment 144936 [details]
Proposed addition: styleForCellFlow.
Comment 2 Ojan Vafai 2012-05-30 16:13:59 PDT 
Comment on attachment 144936 [details]
Proposed addition: styleForCellFlow.

Hyatt might have opinions on the "flow" term. I'm fine with it obviously since I suggested it. :)
Comment 3 WebKit Review Bot 2012-05-30 20:15:24 PDT 
Comment on attachment 144936 [details]
Proposed addition: styleForCellFlow.

Clearing flags on attachment: 144936

Committed r119033: <http://trac.webkit.org/changeset/119033>
Comment 4 WebKit Review Bot 2012-05-30 20:15:30 PDT 
All reviewed patches have been landed.  Closing bug.