Bug 87901 - Avoid second layout for flex-direction:row, flex-basis:auto flex items
Summary: Avoid second layout for flex-direction:row, flex-basis:auto flex items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency treegraph
 
Reported: 2012-05-30 14:48 PDT by Ojan Vafai
Modified: 2012-05-30 18:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.08 KB, patch)
2012-05-30 14:49 PDT, Ojan Vafai
tony: review+
ojan: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-05-30 14:48:05 PDT
Avoid second layout for flex-direction:row, flex-basis:auto flex items
Comment 1 Ojan Vafai 2012-05-30 14:49:06 PDT
Created attachment 144928 [details]
Patch
Comment 2 Tony Chang 2012-05-30 15:50:28 PDT
Comment on attachment 144928 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144928&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:997
> +        // FIXME: If we're overriding logicalHeight (i.e. hasOrthogonalFlow(child) == true), we only need to layout here if the
> +        // contents of the child depends on it's height (e.g. % height elements, background-color, etc) because we already
> +        // layed out once in computeMainAxisPreferredSizes at the unflexed height.

Nit: Might be easier to file a bug about this and dump some of this in the bug instead.
Comment 3 Ojan Vafai 2012-05-30 18:37:14 PDT
Committed r119015: <http://trac.webkit.org/changeset/119015>