Bug 87893 – [Chromium] Chromium DRT should be able to load external resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

For relay performance tests, we need DRT to be loading external resources.

[Ryosuke Niwa]

Created attachment 144913 [details]
Adds the feature

[Ryosuke Niwa]

Created attachment 144915 [details]
Removed replay test changes in webkitpy

[Dirk Pranke]

Comment on attachment 144915 [details]
Removed replay test changes in webkitpy

Hm. I thought this was already supported behind a flag or something, but I guess not. Looks fine to me.

[WebKit Review Bot]

Attachment 144915 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/c..." exit_code: 1
Tools/DumpRenderTree/chromium/WebViewHost.cpp:1209:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

Comment on attachment 144915 [details]
Removed replay test changes in webkitpy

View in context: https://bugs.webkit.org/attachment.cgi?id=144915&action=review

>> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1209
>> +static void blockRequest(WebURLRequest& request) {
> 
> Place brace on its own line for function definitions.  [whitespace/braces] [4]

Oops, will fix.

[Kent Tamura]

Comment on attachment 144915 [details]
Removed replay test changes in webkitpy

View in context: https://bugs.webkit.org/attachment.cgi?id=144915&action=review

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:-1248
> -        && !m_shell->allowExternalPages()) {

So, we can remove TestShell::allowExternalPages() ?

[Ryosuke Niwa]

Comment on attachment 144915 [details]
Removed replay test changes in webkitpy

View in context: https://bugs.webkit.org/attachment.cgi?id=144915&action=review

>> Tools/DumpRenderTree/chromium/WebViewHost.cpp:-1248
>> -        && !m_shell->allowExternalPages()) {
> 
> So, we can remove TestShell::allowExternalPages() ?

Oh oops, I forgot to add that condition :( Will fix.

[WebKit Review Bot]

Comment on attachment 144915 [details]
Removed replay test changes in webkitpy

Attachment 144915 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12865086

New failing tests:
fast/ruby/generated-before-counter-doesnt-crash.html
fast/loader/null-request-after-willSendRequest.html
fast/css-generated-content/malformed-url.html
fast/loader/javascript-url-iframe-remove-on-navigate.html
fast/ruby/before-table-doesnt-crash.html
svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
fast/ruby/before-block-doesnt-crash.html

[WebKit Review Bot]

Created attachment 144972 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Ryosuke Niwa]

Committed r119153: <http://trac.webkit.org/changeset/119153>