Bug 87889 - REGRESSION(118913): webarchive/test-xml-stylesheet.xml is failing
Summary: REGRESSION(118913): webarchive/test-xml-stylesheet.xml is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, LayoutTestFailure, MakingBotsRed, Regression
Depends on: 87891
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-30 13:09 PDT by Tim Horton
Modified: 2012-05-31 08:36 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-05-30 13:09:52 PDT 
http://trac.webkit.org/changeset/118913 seems to have caused webarchive/test-xml-stylesheet.xml to fail:

-     <key>WebSubresources</key>
-     <array>
-         <dict>
-             <key>WebResourceData</key>
-             <string>#test {
-   background: green;
- }
- </string>
-             <key>WebResourceMIMEType</key>
-             <string>text/css</string>
-             <key>WebResourceResponse</key>
-             <dict>
-                 <key>MIMEType</key>
-                 <string>text/css</string>
-                 <key>URL</key>
-                 <string>file:///LayoutTests/webarchive/resources/test-xml-stylesheet.css</string>
-                 <key>expectedContentLength</key>
-                 <integer>31</integer>
-             </dict>
-             <key>WebResourceURL</key>
-             <string>file:///LayoutTests/webarchive/resources/test-xml-stylesheet.css</string>
-         </dict>
-     </array>

I will check in failing results.
Comment 1 Radar WebKit Bug Importer 2012-05-30 13:10:53 PDT 
<rdar://problem/11559199>
Comment 2 Alexey Proskuryakov 2012-05-30 13:22:16 PDT 
-    addSubresourceAttributeURLs(urls);
+    if (!isElementNode())
+        return;
+    static_cast<const Element*>(this)->collectSubresourceURLsFromAttributes(urls);

This means that we're not collecting from ProcessingInstructions anyway. An OVERRIDE annotation would have caught that.

I think that the patch should be rolled out. Given that these functions are collecting URLs from more than just element attributes, new names seem misleading (and that's how the regression got introduced anyway). Some kind of renaming (with OVERRIDE) seems appropriate, but it seems easier to do in a new patch.
Comment 3 Alexey Proskuryakov 2012-05-30 13:23:06 PDT 
s/anyway/any more/
Comment 4 Tim Horton 2012-05-30 13:36:57 PDT 
Rolling out in https://bugs.webkit.org/show_bug.cgi?id=87891
Comment 5 Antti Koivisto 2012-05-31 08:15:00 PDT 
Please don't roll out large patches for such minor reasons. This would have been a trivial fix.
Comment 6 Alexey Proskuryakov 2012-05-31 08:36:45 PDT 
Antti, you may have not read comment 2. The idea of this patch was wrong.