RESOLVED FIXED 87889
REGRESSION(118913): webarchive/test-xml-stylesheet.xml is failing 
https://bugs.webkit.org/show_bug.cgi?id=87889
Summary REGRESSION(118913): webarchive/test-xml-stylesheet.xml is failing
Tim Horton
Reported 2012-05-30 13:09:52 PDT
http://trac.webkit.org/changeset/118913 seems to have caused webarchive/test-xml-stylesheet.xml to fail: - <key>WebSubresources</key> - <array> - <dict> - <key>WebResourceData</key> - <string>#test { - background: green; - } - </string> - <key>WebResourceMIMEType</key> - <string>text/css</string> - <key>WebResourceResponse</key> - <dict> - <key>MIMEType</key> - <string>text/css</string> - <key>URL</key> - <string>file:///LayoutTests/webarchive/resources/test-xml-stylesheet.css</string> - <key>expectedContentLength</key> - <integer>31</integer> - </dict> - <key>WebResourceURL</key> - <string>file:///LayoutTests/webarchive/resources/test-xml-stylesheet.css</string> - </dict> - </array> I will check in failing results.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-05-30 13:10:53 PDT
<rdar://problem/11559199>
Alexey Proskuryakov
Comment 2 2012-05-30 13:22:16 PDT
- addSubresourceAttributeURLs(urls); + if (!isElementNode()) + return; + static_cast<const Element*>(this)->collectSubresourceURLsFromAttributes(urls); This means that we're not collecting from ProcessingInstructions anyway. An OVERRIDE annotation would have caught that. I think that the patch should be rolled out. Given that these functions are collecting URLs from more than just element attributes, new names seem misleading (and that's how the regression got introduced anyway). Some kind of renaming (with OVERRIDE) seems appropriate, but it seems easier to do in a new patch.
Alexey Proskuryakov
Comment 3 2012-05-30 13:23:06 PDT
s/anyway/any more/
Tim Horton
Comment 4 2012-05-30 13:36:57 PDT
Rolling out in https://bugs.webkit.org/show_bug.cgi?id=87891
Antti Koivisto
Comment 5 2012-05-31 08:15:00 PDT
Please don't roll out large patches for such minor reasons. This would have been a trivial fix.
Alexey Proskuryakov
Comment 6 2012-05-31 08:36:45 PDT
Antti, you may have not read comment 2. The idea of this patch was wrong.
Note You need to log in before you can comment on or make changes to this bug.