Bug 87889 - REGRESSION(118913): webarchive/test-xml-stylesheet.xml is failing
: REGRESSION(118913): webarchive/test-xml-stylesheet.xml is failing
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
: InRadar, LayoutTestFailure, MakingBot...
: 87891
:
  Show dependency treegraph
 
Reported: 2012-05-30 13:09 PST by
Modified: 2012-05-31 08:36 PST (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-05-30 13:09:52 PST
http://trac.webkit.org/changeset/118913 seems to have caused webarchive/test-xml-stylesheet.xml to fail:

-     <key>WebSubresources</key>
-     <array>
-         <dict>
-             <key>WebResourceData</key>
-             <string>#test {
-   background: green;
- }
- </string>
-             <key>WebResourceMIMEType</key>
-             <string>text/css</string>
-             <key>WebResourceResponse</key>
-             <dict>
-                 <key>MIMEType</key>
-                 <string>text/css</string>
-                 <key>URL</key>
-                 <string>file:///LayoutTests/webarchive/resources/test-xml-stylesheet.css</string>
-                 <key>expectedContentLength</key>
-                 <integer>31</integer>
-             </dict>
-             <key>WebResourceURL</key>
-             <string>file:///LayoutTests/webarchive/resources/test-xml-stylesheet.css</string>
-         </dict>
-     </array>

I will check in failing results.
------- Comment #1 From 2012-05-30 13:10:53 PST -------
<rdar://problem/11559199>
------- Comment #2 From 2012-05-30 13:22:16 PST -------
-    addSubresourceAttributeURLs(urls);
+    if (!isElementNode())
+        return;
+    static_cast<const Element*>(this)->collectSubresourceURLsFromAttributes(urls);

This means that we're not collecting from ProcessingInstructions anyway. An OVERRIDE annotation would have caught that.

I think that the patch should be rolled out. Given that these functions are collecting URLs from more than just element attributes, new names seem misleading (and that's how the regression got introduced anyway). Some kind of renaming (with OVERRIDE) seems appropriate, but it seems easier to do in a new patch.
------- Comment #3 From 2012-05-30 13:23:06 PST -------
s/anyway/any more/
------- Comment #4 From 2012-05-30 13:36:57 PST -------
Rolling out in https://bugs.webkit.org/show_bug.cgi?id=87891
------- Comment #5 From 2012-05-31 08:15:00 PST -------
Please don't roll out large patches for such minor reasons. This would have been a trivial fix.
------- Comment #6 From 2012-05-31 08:36:45 PST -------
Antti, you may have not read comment 2. The idea of this patch was wrong.