Bug 87881 - Only include the image checksum error in pretty-diffs for -expected.png files.
Summary: Only include the image checksum error in pretty-diffs for -expected.png files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-30 11:26 PDT by Ojan Vafai
Modified: 2012-05-30 18:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2012-05-30 11:27 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Add another test-case (4.58 KB, patch)
2012-05-30 11:31 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-05-30 11:26:43 PDT 
Only include the image checksum error in pretty-diffs for -expected.png files.
Comment 1 Ojan Vafai 2012-05-30 11:27:13 PDT 
Created attachment 144878 [details]
Patch
Comment 2 Ojan Vafai 2012-05-30 11:31:44 PDT 
Created attachment 144880 [details]
Add another test-case
Comment 3 Dirk Pranke 2012-05-30 13:52:24 PDT 
Do we actually have a driver for ruby tests?
Comment 4 Ojan Vafai 2012-05-30 14:25:52 PDT 
(In reply to comment #3)
> Do we actually have a driver for ruby tests?

I don't believe so. I've just be loading the test locally.
Comment 5 WebKit Review Bot 2012-05-30 18:01:32 PDT 
Comment on attachment 144880 [details]
Add another test-case

Clearing flags on attachment: 144880

Committed r119010: <http://trac.webkit.org/changeset/119010>
Comment 6 WebKit Review Bot 2012-05-30 18:01:39 PDT 
All reviewed patches have been landed.  Closing bug.