Bug 87872 – [Qt] Implement a shim layer to wrap v8 behind the JavaScriptCore API

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Platform

[Balazs Kelemen]

The goal is to be able to use v8 in WebKit2 without the need to fork the InjectedBundle (of WTR).

[Balazs Kelemen]

Created attachment 145093 [details]
Patch

[Alexey Proskuryakov]

This is part of "make WebKit2 work with v8" project that has not been accepted on webkit-dev. Why is it ok to post this for review?

[Balazs Kelemen]

(In reply to comment #2)
> This is part of "make WebKit2 work with v8" project that has not been accepted on webkit-dev. Why is it ok to post this for review?

It has not been rejected unambiguously as well. I finished implementing this so the community can at least see how it looks like. It's better to decide on something that actually exist.

[Alexey Proskuryakov]

That's not how I read the discussion.

Anyway, if this is your goal, I suggest clearing the review flag and posting to webkit-dev again with a link. This patch is not something that should be r+'ed and landed without community buy-in.

[Balazs Kelemen]

(In reply to comment #4)
> That's not how I read the discussion.
> 
> Anyway, if this is your goal, I suggest clearing the review flag and posting to webkit-dev again with a link. This patch is not something that should be r+'ed and landed without community buy-in.

Mail sent. I would better like to keep the r? because otherwise nobody will notice the patch (according to my experiences).

[Adam Barth]

This wrapper looks like it's pretty slow.  Have you benchmarked it?

[Balazs Kelemen]

(In reply to comment #6)
> This wrapper looks like it's pretty slow.  Have you benchmarked it?

Not yet. Considering that the wrapper is only taking part in binding layouttestcontroller and friends to the js environment I don't really care about speed. Note that the actual script execution is happening in WebCore, not WebKit2. Most of the js related thinks in WebKit2 are just for serving the needs of the injected bundle. As long as a test session does not takes considerably more time than before, I don't think we should worry about speed.

[Alexey Proskuryakov]

WONTFIX per complete lack of buy-in on webkit-dev.