Bug 87869 - [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
Summary: [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-30 10:06 PDT by Chris Dumez
Modified: 2012-06-04 00:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2012-05-30 10:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-05-30 10:06:27 PDT 
The "%lld" format specifier is used to print an int64_t value in DumpRenderTreeView.cpp. This causes a warning on 64-Bit where "%ld" is expected.
We should make use of the PRId64 macro from inttypes.h to avoid this issue.
Comment 1 Chris Dumez 2012-05-30 10:10:39 PDT 
Created attachment 144851 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-30 10:38:51 PDT 
Comment on attachment 144851 [details]
Patch

Looks good.
Comment 3 Gyuyoung Kim 2012-05-30 17:33:51 PDT 
Comment on attachment 144851 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2012-06-04 00:00:33 PDT 
Comment on attachment 144851 [details]
Patch

Clearing flags on attachment: 144851

Committed r119373: <http://trac.webkit.org/changeset/119373>
Comment 5 WebKit Review Bot 2012-06-04 00:00:38 PDT 
All reviewed patches have been landed.  Closing bug.