Bug 87866 - [GTK][WK2] Errors in documentation about webkit_web_view_run_javascript()
Summary: [GTK][WK2] Errors in documentation about webkit_web_view_run_javascript()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-05-30 09:58 PDT by Mario Sanchez Prada
Modified: 2012-05-30 15:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch proposal (3.05 KB, patch)
2012-05-30 10:02 PDT, Mario Sanchez Prada 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2012-05-30 09:58:56 PDT 
The snippet of code provided as documentation for webkit_web_view_run_javascript() and webkit_web_view_run_javascript_finish () in WebKit2GTK API contains some errors that should be fixed.
Comment 1 Mario Sanchez Prada 2012-05-30 10:02:19 PDT 
Created attachment 144847 [details]
Patch proposal
Comment 2 WebKit Review Bot 2012-05-30 10:05:55 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Mario Sanchez Prada 2012-05-30 10:08:29 PDT 
Comment on attachment 144847 [details]
Patch proposal

Let's get the CQ do the work...
Comment 4 WebKit Review Bot 2012-05-30 15:38:04 PDT 
Comment on attachment 144847 [details]
Patch proposal

Clearing flags on attachment: 144847

Committed r118985: <http://trac.webkit.org/changeset/118985>
Comment 5 WebKit Review Bot 2012-05-30 15:38:08 PDT 
All reviewed patches have been landed.  Closing bug.