Bug 87865 - IndexedDB: Implement IDBTransaction.error and IDBRequest.error
Summary: IndexedDB: Implement IDBTransaction.error and IDBRequest.error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords: WebExposed
Depends on: 87914
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-30 09:55 PDT by Alec Flett
Modified: 2012-06-08 14:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (155.57 KB, patch)
2012-05-30 10:05 PDT, Alec Flett 		no flags Details | Formatted Diff | Diff
Patch (155.67 KB, patch)
2012-05-30 10:12 PDT, Alec Flett 		no flags Details | Formatted Diff | Diff
Patch (158.04 KB, patch)
2012-05-31 12:23 PDT, Alec Flett 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2012-05-30 09:55:42 PDT 
IndexedDB: Implement IDBTransaction.error and IDBRequest.error
Comment 1 Alec Flett 2012-05-30 10:05:53 PDT 
Created attachment 144850 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-30 10:09:41 PDT 
Attachment 144850 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/stor..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 77 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alec Flett 2012-05-30 10:12:25 PDT 
Created attachment 144853 [details]
Patch
Comment 4 Alec Flett 2012-05-30 10:56:08 PDT 
Comment on attachment 144853 [details]
Patch

tony@ - r? cq? This builds on yesterday's patch and I have another one following. Most of the patch here is mechanical test updates. Obviously the meat is in the C++, but even that is pretty minor code cleanup.
Comment 5 Alec Flett 2012-05-30 10:56:34 PDT 
oops, trying again with tony on the CC:
tony@ - r? cq?
Comment 6 WebKit Review Bot 2012-05-30 15:39:45 PDT 
Comment on attachment 144853 [details]
Patch

Clearing flags on attachment: 144853

Committed r118986: <http://trac.webkit.org/changeset/118986>
Comment 7 WebKit Review Bot 2012-05-30 15:39:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2012-05-30 18:18:16 PDT 
Re-opened since this is blocked by 87914
Comment 9 Alec Flett 2012-05-31 12:23:06 PDT 
Created attachment 145131 [details]
Patch
Comment 10 Alec Flett 2012-05-31 13:47:53 PDT 
Comment on attachment 145131 [details]
Patch

ok, trying again - the chrome bug revealed a tiny bug in the proxy code (note the change from code() to idbCode() in the chromium/src stuff) and also the test expectations weren't updated for shared workers since they require browser tests to be run.

tony@ - r? cq?
Comment 11 WebKit Review Bot 2012-05-31 15:47:52 PDT 
Comment on attachment 145131 [details]
Patch

Clearing flags on attachment: 145131

Committed r119161: <http://trac.webkit.org/changeset/119161>
Comment 12 WebKit Review Bot 2012-05-31 15:47:57 PDT 
All reviewed patches have been landed.  Closing bug.