Bug 87861 - [BlackBerry] Minor string conversion bug
Summary: [BlackBerry] Minor string conversion bug
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Other
: P2 Normal
Assignee: Joe Mason
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-30 09:17 PDT by Joe Mason
Modified: 2012-05-30 16:07 PDT (History)
1 user (show)

See Also:

Attachments
fix (2.19 KB, patch)
2012-05-30 09:39 PDT, Joe Mason 		no flags Details | Formatted Diff | Diff
fix with changelogs (3.17 KB, patch)
2012-05-30 10:38 PDT, Joe Mason 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Mason 2012-05-30 09:17:44 PDT 
In NetworkJob:

username is a WTF::String.  ResourceHandleInternal::m_user is a string.  Yet they're assigned with "username = m_user.utf8().data()".  Pointless: "username = m_user" will do.
Comment 1 Joe Mason 2012-05-30 09:39:36 PDT 
Created attachment 144841 [details]
fix
Comment 2 Joe Mason 2012-05-30 10:38:53 PDT 
Created attachment 144864 [details]
fix with changelogs
Comment 3 WebKit Review Bot 2012-05-30 16:07:36 PDT 
Comment on attachment 144864 [details]
fix with changelogs

Clearing flags on attachment: 144864

Committed r118991: <http://trac.webkit.org/changeset/118991>
Comment 4 WebKit Review Bot 2012-05-30 16:07:40 PDT 
All reviewed patches have been landed.  Closing bug.