Bug 87854 - Port RAMSize to WinCE
Summary: Port RAMSize to WinCE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-30 07:57 PDT by Patrick R. Gansterer
Modified: 2012-06-04 12:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.14 KB, patch)
2012-05-30 08:01 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (1.20 KB, patch)
2012-05-30 10:23 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-05-30 07:57:43 PDT 
Port RAMSiize to WinCE
Comment 1 Patrick R. Gansterer 2012-05-30 08:01:11 PDT 
Created attachment 144818 [details]
Patch
Comment 2 Geoffrey Garen 2012-05-30 10:12:52 PDT 
Comment on attachment 144818 [details]
Patch

Please check for an error return value from GlobalMemoryStatus.
Comment 3 Patrick R. Gansterer 2012-05-30 10:14:17 PDT 
Comment on attachment 144818 [details]
Patch

(In reply to comment #2)
> (From update of attachment 144818 [details])
> Please check for an error return value from GlobalMemoryStatus.

See http://msdn.microsoft.com/en-us/library/ms908470.aspx:
GlobalMemoryStatus has no return value.
Comment 4 Geoffrey Garen 2012-05-30 10:19:57 PDT 
> On computers with more than 4 GB of memory, the GlobalMemoryStatus function can return
> incorrect information, reporting a value of –1 to indicate an overflow. 

This is what I meant by "error return".
Comment 5 Patrick R. Gansterer 2012-05-30 10:23:48 PDT 
Created attachment 144859 [details]
Patch
Comment 6 Patrick R. Gansterer 2012-06-04 09:45:21 PDT 
ping?
Comment 7 Geoffrey Garen 2012-06-04 11:58:56 PDT 
Comment on attachment 144859 [details]
Patch

r=me
Comment 8 WebKit Review Bot 2012-06-04 12:15:02 PDT 
Comment on attachment 144859 [details]
Patch

Clearing flags on attachment: 144859

Committed r119412: <http://trac.webkit.org/changeset/119412>
Comment 9 WebKit Review Bot 2012-06-04 12:15:06 PDT 
All reviewed patches have been landed.  Closing bug.