Bug 87852 - [Chromium] Call fileUtilities methods directly
: [Chromium] Call fileUtilities methods directly
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Mark Pilgrim (Google)
:
Depends on:
Blocks: 82948
  Show dependency treegraph
 
Reported: 2012-05-30 07:39 PDT by Mark Pilgrim (Google)
Modified: 2012-05-30 19:31 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.87 KB, patch)
2012-05-30 07:40 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (12.00 KB, patch)
2012-05-30 12:08 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (11.89 KB, patch)
2012-05-30 13:24 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (11.88 KB, patch)
2012-05-30 13:30 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-30 07:39:46 PDT
[Chromium] Call fileUtilities methods directly
Comment 1 Mark Pilgrim (Google) 2012-05-30 07:40:25 PDT
Created attachment 144812 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-05-30 07:41:56 PDT
Please check the changes to DragDataChromium.cpp very carefully! I'm not sure I got the casts right.
Comment 3 James Robinson 2012-05-30 09:40:05 PDT
Comment on attachment 144812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144812&action=review

> Source/WebCore/platform/chromium/DragDataChromium.cpp:65
> +        url = static_cast<KURL>(WebKit::Platform::current()->fileUtilities()->filePathToURL(static_cast<String>(WebKit::Platform::current()->fileUtilities()->getAbsolutePath(m_platformDragData->filenames()[0]))));

This needs some temporaries at least - I can't tell if it's correct or not.

static_cast<> is the wrong way to convert from, say, a WebString to a String - instead you want to call String(myWebString)
Comment 4 Mark Pilgrim (Google) 2012-05-30 12:08:36 PDT
Created attachment 144890 [details]
Patch
Comment 5 Mark Pilgrim (Google) 2012-05-30 12:09:06 PDT
Comment on attachment 144890 [details]
Patch

Added intermediate variables, cast to String properly.
Comment 6 Adam Barth 2012-05-30 13:21:55 PDT
Comment on attachment 144890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144890&action=review

> Source/WebCore/platform/chromium/DragDataChromium.cpp:62
> +    String path;

You can move this declaration inside the "else if" since it's only used there.
Comment 7 Mark Pilgrim (Google) 2012-05-30 13:24:38 PDT
Created attachment 144904 [details]
Patch
Comment 8 Mark Pilgrim (Google) 2012-05-30 13:25:05 PDT
Comment on attachment 144904 [details]
Patch

Moved variable declaration.
Comment 9 Adam Barth 2012-05-30 13:28:03 PDT
Comment on attachment 144904 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144904&action=review

> Source/WebCore/platform/chromium/DragDataChromium.cpp:66
> +        String path;
> +        path = String(WebKit::Platform::current()->fileUtilities()->getAbsolutePath(m_platformDragData->filenames()[0]));

These can just be put on one line.
Comment 10 Mark Pilgrim (Google) 2012-05-30 13:30:41 PDT
Created attachment 144907 [details]
Patch
Comment 11 WebKit Review Bot 2012-05-30 19:31:54 PDT
Comment on attachment 144907 [details]
Patch

Clearing flags on attachment: 144907

Committed r119024: <http://trac.webkit.org/changeset/119024>
Comment 12 WebKit Review Bot 2012-05-30 19:31:59 PDT
All reviewed patches have been landed.  Closing bug.