Bug 87833 - [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
Summary: [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-30 01:39 PDT by Mikhail Pozdnyakov
Modified: 2012-05-30 09:32 PDT (History)
5 users (show)

See Also:

Attachments
patch (2.92 KB, patch)
2012-05-30 01:49 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
patch v2 (corrected changelog) (2.92 KB, patch)
2012-05-30 02:08 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-05-30 01:39:56 PDT 
EFL's DRT needs "postProgressFinishedNotification" message in order to unskip http/tests/loading/progress-finished-callback.html
Comment 1 Mikhail Pozdnyakov 2012-05-30 01:49:12 PDT 
Created attachment 144753 [details]
patch
Comment 2 Gyuyoung Kim 2012-05-30 01:55:38 PDT 
Comment on attachment 144753 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144753&action=review

LGTM.

> LayoutTests/ChangeLog:3
> +        [EFL][DRT] EFL's DRT needs  "postProgressFinishedNotification" message

There is two spaces between *needs* and *"post.

> Tools/ChangeLog:3
> +        [EFL][DRT] EFL's DRT needs  "postProgressFinishedNotification" message

ditto.
Comment 3 Mikhail Pozdnyakov 2012-05-30 02:08:07 PDT 
Created attachment 144757 [details]
patch v2 (corrected changelog)
Comment 4 Mikhail Pozdnyakov 2012-05-30 02:08:39 PDT 
(In reply to comment #2)
> (From update of attachment 144753 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144753&action=review
> 
> LGTM.
> 
> > LayoutTests/ChangeLog:3
> > +        [EFL][DRT] EFL's DRT needs  "postProgressFinishedNotification" message
> 
> There is two spaces between *needs* and *"post.
> 
> > Tools/ChangeLog:3
> > +        [EFL][DRT] EFL's DRT needs  "postProgressFinishedNotification" message
> 
> ditto.

Thanks. Fixed.
Comment 5 Gyuyoung Kim 2012-05-30 03:02:07 PDT 
Comment on attachment 144757 [details]
patch v2 (corrected changelog)

LGTM.
Comment 6 WebKit Review Bot 2012-05-30 06:55:29 PDT 
Comment on attachment 144757 [details]
patch v2 (corrected changelog)

Clearing flags on attachment: 144757

Committed r118918: <http://trac.webkit.org/changeset/118918>
Comment 7 WebKit Review Bot 2012-05-30 06:55:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Thiago Marcos P. Santos 2012-05-30 08:05:33 PDT 
We have this new failure on the bot after this patch landed:

http/tests/local/fileapi/file-last-modified-after-delete.html

Mikhail, do you mind having a look?
Comment 9 Mikhail Pozdnyakov 2012-05-30 09:32:43 PDT 
(In reply to comment #8)
> We have this new failure on the bot after this patch landed:
> 
> http/tests/local/fileapi/file-last-modified-after-delete.html
> 
> Mikhail, do you mind having a look?

Seems to be unrelated