Bug 87820 - [V8][Performance] Optimize DOM attribute getters that return an empty string
Summary: [V8][Performance] Optimize DOM attribute getters that return an empty string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency treegraph
 
Reported: 2012-05-29 21:40 PDT by Kentaro Hara
Modified: 2012-05-30 17:30 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.00 KB, patch)
2012-05-29 21:48 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-29 21:40:38 PDT
We can optimize the performance of DOM attribute getters that return an empty string (e.g. div.id, div.className, div.title, div.lang ...etc)

- by passing Isolate to v8::String::Empty(); and
- by inlining V8Binding::getElementStringAttr()
Comment 1 Kentaro Hara 2012-05-29 21:48:02 PDT
Created attachment 144698 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-30 17:30:28 PDT
Comment on attachment 144698 [details]
Patch

Clearing flags on attachment: 144698

Committed r119004: <http://trac.webkit.org/changeset/119004>
Comment 3 WebKit Review Bot 2012-05-30 17:30:32 PDT
All reviewed patches have been landed.  Closing bug.