WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
8782
use ICU and UChar more, QChar less
https://bugs.webkit.org/show_bug.cgi?id=8782
Summary
use ICU and UChar more, QChar less
Darin Adler
Reported
2006-05-07 21:46:55 PDT
Time to convert WebCore::String and lots of other code to use UChar directly, and cut down QChar use. Soon we can eliminate QChar.
Attachments
patch that works and passes layout tests; still needs performance testing
(283.25 KB, patch)
2006-05-07 22:52 PDT
,
Darin Adler
hyatt
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2006-05-07 22:52:08 PDT
Created
attachment 8160
[details]
patch that works and passes layout tests; still needs performance testing
Dave Hyatt
Comment 2
2006-05-08 11:57:51 PDT
Comment on
attachment 8160
[details]
patch that works and passes layout tests; still needs performance testing rs=me
Darin Adler
Comment 3
2006-05-08 19:39:29 PDT
Ironically, we probably want to move to a platform-independent Unicode layer instead of using ICU directly, but that can be a next step.
mitz
Comment 4
2006-05-09 22:23:43 PDT
The commit included changes to render_style.cpp that didn't appear in the patch and include a typo in RenderStyel::getPseduoStyle. That change is essentially part of the fix for
bug 8789
, but without the other part, I think this is going to break one of the layout tests.
Timothy Hatcher
Comment 5
2006-05-09 22:54:18 PDT
Landed in
r14273
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug