Bug 87817 - [BlackBerry] The Page's deviceScaleFactor() is not being properly maintained
Summary: [BlackBerry] The Page's deviceScaleFactor() is not being properly maintained
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Max Feil
URL:
Keywords:
Depends on:
Blocks: 87551
  Show dependency tree / graph
 
Reported: 2012-05-29 21:18 PDT by Max Feil
Modified: 2012-11-02 12:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2012-05-29 21:34 PDT, Max Feil 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Feil 2012-05-29 21:18:17 PDT 
When navigating between web pages with different CSS pixel sizes, the deviceScaleFactor is not maintained properly. Specifically, when navigating from a page with a deviceScaleFactor greater than one to a page with the default deviceScaleFactor of 1.0.

My patch fixes two spots in the code. One where viewport changes from non-default to default are being erroneously thrown out, and another where viewport changes back to default are recognized but deviceScaleFactor is not being updated.
Comment 1 Max Feil 2012-05-29 21:34:05 PDT 
Created attachment 144695 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-29 23:18:04 PDT 
Comment on attachment 144695 [details]
Patch

Clearing flags on attachment: 144695

Committed r118895: <http://trac.webkit.org/changeset/118895>
Comment 3 WebKit Review Bot 2012-05-29 23:18:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Max Feil 2012-11-02 12:43:12 PDT 
Closing bug for patch that landed a long time ago.