WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87810
[V8] Replace v8::Null() with v8::Null(isolate) or v8NullWithCheck(isolate) in non-custom bindings
https://bugs.webkit.org/show_bug.cgi?id=87810
Summary
[V8] Replace v8::Null() with v8::Null(isolate) or v8NullWithCheck(isolate) in...
Kentaro Hara
Reported
2012-05-29 19:16:02 PDT
The objective is to pass Isolate around in V8 bindings. For non-custom bindings, we replace v8::Null() with v8::Null(isolate) where isolate cannot be 0, and replace v8::Null() with v8NullWithCheck(isolate) where isolate can be 0. That's it for v8::Null().
Attachments
Patch
(9.17 KB, patch)
2012-05-29 19:18 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-05-29 19:18:59 PDT
Created
attachment 144679
[details]
Patch
WebKit Review Bot
Comment 2
2012-05-30 17:11:37 PDT
Comment on
attachment 144679
[details]
Patch Clearing flags on attachment: 144679 Committed
r118999
: <
http://trac.webkit.org/changeset/118999
>
WebKit Review Bot
Comment 3
2012-05-30 17:11:41 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug