Bug 87810 - [V8] Replace v8::Null() with v8::Null(isolate) or v8NullWithCheck(isolate) in non-custom bindings
Summary: [V8] Replace v8::Null() with v8::Null(isolate) or v8NullWithCheck(isolate) in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency tree / graph
 
Reported: 2012-05-29 19:16 PDT by Kentaro Hara
Modified: 2012-05-30 17:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.17 KB, patch)
2012-05-29 19:18 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-29 19:16:02 PDT 
The objective is to pass Isolate around in V8 bindings.

For non-custom bindings, we replace v8::Null() with v8::Null(isolate) where isolate cannot be 0, and replace v8::Null() with v8NullWithCheck(isolate) where isolate can be 0.

That's it for v8::Null().
Comment 1 Kentaro Hara 2012-05-29 19:18:59 PDT 
Created attachment 144679 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-30 17:11:37 PDT 
Comment on attachment 144679 [details]
Patch

Clearing flags on attachment: 144679

Committed r118999: <http://trac.webkit.org/changeset/118999>
Comment 3 WebKit Review Bot 2012-05-30 17:11:41 PDT 
All reviewed patches have been landed.  Closing bug.