All the gesture recognition is canceled when a touch event is handled by webprocess. If the touchmove event is handled by javascript then any touchmove, does not matter the length of the movement, will cancel the tap gesture recognition.
(In reply to comment #0) > All the gesture recognition is canceled when a touch event is handled by webprocess. > > If the touchmove event is handled by javascript then any touchmove, does not matter the length of the movement, will cancel the tap gesture recognition. If I understood it correctly, we do the same for the blackberry port.
Created attachment 144870 [details] patch
Comment on attachment 144870 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=144870&action=review LGTM, but please cc Andras > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:-439 > - resetGestureRecognizers(); Maybe that method is useless now? Did you check?
(In reply to comment #3) > (From update of attachment 144870 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144870&action=review > > LGTM, but please cc Andras > > > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:-439 > > - resetGestureRecognizers(); > > Maybe that method is useless now? Did you check? It is used by QQuickWebViewPrivate::processDidCrash.
Comment on attachment 144870 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=144870&action=review >>> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:-439 >>> - resetGestureRecognizers(); >> >> Maybe that method is useless now? Did you check? > > It is used by QQuickWebViewPrivate::processDidCrash. OK, but I guess I will just do the cancels explicitly there instead...
Comment on attachment 144870 [details] patch Clearing flags on attachment: 144870 Committed r118997: <http://trac.webkit.org/changeset/118997>
All reviewed patches have been landed. Closing bug.
(In reply to comment #5) > (From update of attachment 144870 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144870&action=review > > >>> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:-439 > >>> - resetGestureRecognizers(); > >> > >> Maybe that method is useless now? Did you check? > > > > It is used by QQuickWebViewPrivate::processDidCrash. > > OK, but I guess I will just do the cancels explicitly there instead... I'm working on a patch which removes that function and also the base class of the recognizers as discussed earlier, but first I want to simplify the tap gesture recognizer a bit.