Bug 87801 - [GTK] Remove geoclue dependency from WebKit API Layer
Summary: [GTK] Remove geoclue dependency from WebKit API Layer
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on: 87800
  Show dependency treegraph
Reported: 2012-05-29 17:58 PDT by Mario Sanchez Prada
Modified: 2012-06-04 02:06 PDT (History)
5 users (show)

See Also:

Patch proposal (11.17 KB, patch)
2012-05-29 18:17 PDT, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff
Patch proposal (10.29 KB, patch)
2012-05-31 02:52 PDT, Mario Sanchez Prada
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2012-05-29 17:58:59 PDT
Once we have bug 87800 fixed, we should be able to remove the geoclue dependency from the API layer and write GeolocationClientGtk.cpp in terms of a geoclue-based geolocation provider in WebCore.

This bug is for that.
Comment 1 Mario Sanchez Prada 2012-05-29 18:17:04 PDT
Created attachment 144665 [details]
Patch proposal
Comment 2 Martin Robinson 2012-05-29 18:20:15 PDT
Comment on attachment 144665 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=144665&action=review

> Source/WebKit/gtk/GNUmakefile.am:-60

I'm pretty certain you need to keep these flags here. Note that libxslt is on the list.

> Source/WebKit/gtk/WebCoreSupport/GeolocationClientGtk.h:62
> +    RefPtr<WebCore::GeolocationProviderGeoclue> m_provider;

Instead of making this reference-counted and a pointer, it makes more sense, I think, to just make it a member, ie

WebCore::GeolocationProvider m_provider;

You can then initialize it like this

, m_provider(this)
Comment 3 WebKit Review Bot 2012-05-29 18:20:52 PDT
Attachment 144665 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/gtk/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mario Sanchez Prada 2012-05-31 02:52:38 PDT
Created attachment 145033 [details]
Patch proposal

New patch, addressing issues raised by Martin
Comment 5 Mario Sanchez Prada 2012-06-01 03:07:53 PDT
Thansk for the review, Martin. I will push it as soon as I get the dependencies ready too.

Note to myself: fix the following typo in this patch when landing:

-void GeolocationClient::notifyErrorOcurred(const char* message)
+void GeolocationClient::notifyErrorOccurred(const char* message)
Comment 6 Mario Sanchez Prada 2012-06-04 02:06:42 PDT
Committed r119376: <http://trac.webkit.org/changeset/119376>