WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87795
nrwt: seems to leak temp dirs
https://bugs.webkit.org/show_bug.cgi?id=87795
Summary
nrwt: seems to leak temp dirs
Dirk Pranke
Reported
2012-05-29 17:07:03 PDT
nrwt: seems to leak temp dirs
Attachments
Patch
(6.22 KB, patch)
2012-05-29 17:12 PDT
,
Dirk Pranke
ojan
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2012-05-29 17:12:04 PDT
Created
attachment 144649
[details]
Patch
Ojan Vafai
Comment 2
2012-05-29 20:12:24 PDT
Comment on
attachment 144649
[details]
Patch __del__ aside, I like this code better. It's more clear when things happen.
Eric Seidel (no email)
Comment 3
2012-05-29 21:03:58 PDT
Comment on
attachment 144649
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=144649&action=review
> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:-463 > - def __del__(self): > - self._port._filesystem.rmtree(str(self._driver_tempdir))
Maybe we should ASSERT that stop_driver was called? i.e. that _driver_tempdir was set back to None?
Dirk Pranke
Comment 4
2012-05-30 14:53:53 PDT
(In reply to
comment #3
)
> (From update of
attachment 144649
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=144649&action=review
> > > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:-463 > > - def __del__(self): > > - self._port._filesystem.rmtree(str(self._driver_tempdir)) > > Maybe we should ASSERT that stop_driver was called? i.e. that _driver_tempdir was set back to None?
Sure, I can add that.
Dirk Pranke
Comment 5
2012-05-30 14:59:11 PDT
Committed
r118979
: <
http://trac.webkit.org/changeset/118979
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug