nrwt: seems to leak temp dirs
Created attachment 144649 [details] Patch
Comment on attachment 144649 [details] Patch __del__ aside, I like this code better. It's more clear when things happen.
Comment on attachment 144649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144649&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:-463 > - def __del__(self): > - self._port._filesystem.rmtree(str(self._driver_tempdir)) Maybe we should ASSERT that stop_driver was called? i.e. that _driver_tempdir was set back to None?
(In reply to comment #3) > (From update of attachment 144649 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144649&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:-463 > > - def __del__(self): > > - self._port._filesystem.rmtree(str(self._driver_tempdir)) > > Maybe we should ASSERT that stop_driver was called? i.e. that _driver_tempdir was set back to None? Sure, I can add that.
Committed r118979: <http://trac.webkit.org/changeset/118979>