Bug 87795 - nrwt: seems to leak temp dirs
Summary: nrwt: seems to leak temp dirs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 17:07 PDT by Dirk Pranke
Modified: 2012-05-30 14:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.22 KB, patch)
2012-05-29 17:12 PDT, Dirk Pranke
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-05-29 17:07:03 PDT
nrwt: seems to leak temp dirs
Comment 1 Dirk Pranke 2012-05-29 17:12:04 PDT
Created attachment 144649 [details]
Patch
Comment 2 Ojan Vafai 2012-05-29 20:12:24 PDT
Comment on attachment 144649 [details]
Patch

__del__ aside, I like this code better. It's more clear when things happen.
Comment 3 Eric Seidel (no email) 2012-05-29 21:03:58 PDT
Comment on attachment 144649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144649&action=review

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:-463
> -    def __del__(self):
> -        self._port._filesystem.rmtree(str(self._driver_tempdir))

Maybe we should ASSERT that stop_driver was called?  i.e. that _driver_tempdir was set back to None?
Comment 4 Dirk Pranke 2012-05-30 14:53:53 PDT
(In reply to comment #3)
> (From update of attachment 144649 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144649&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:-463
> > -    def __del__(self):
> > -        self._port._filesystem.rmtree(str(self._driver_tempdir))
> 
> Maybe we should ASSERT that stop_driver was called?  i.e. that _driver_tempdir was set back to None?

Sure, I can add that.
Comment 5 Dirk Pranke 2012-05-30 14:59:11 PDT
Committed r118979: <http://trac.webkit.org/changeset/118979>